tarantool / luajit / 12984029852

93%

Build Type

push

github

Committed by Buristan

Commit Message

FFI: Add missing coercion when recording 64-bit bit.*().

Thanks to Peter Cawley.

(cherry picked from commit 304da39cc)

Before the patch, with the missed coercion from string, there is the
cast to `i64` from `p64`, where the last one is the string address. This
leads to an incorrect result of the bit operation.

This patch adds the missing coercion everywhere for bit operations
recording. Only the `recff_bit64_nary()` is affected, since all other
routines have the corresponding type check and cast emitting if
necessary. However, for the consistency, all functions have the same
checking routine `crec_bit64_arg()` now.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#10709

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

Run Details

5694 of 6033 branches covered (94.38%)

Branch coverage included in aggregate %.

11 of 15 new or added lines in 1 file covered. (73.33%)

2 existing lines in 2 files now uncovered.

21699 of 23437 relevant lines covered (92.58%)

2965359.2 hits per line