broadinstitute / viral-core

69%

master: 69%

LAST BUILD ON BRANCH dp-splitcode

branch: dp-splitcode

CHANGE BRANCH

x

Reset

• dp-splitcode
• ct-add-fgbio
• ct-add-ncbi-datasets
• ct-add-read-filtering-cli-cmd
• ct-align_and_fix_without_supplementary_alignments
• ct-barcode-helper-ntc-counting
• ct-barcode-i5-single-index-bugfix
• ct-bugfix-idxstats-fns
• ct-bugfix-minimap2_idxstats
• ct-bump-baseimage
• ct-bump-baseimage-0.2.3
• ct-bump-pysam
• ct-bump-pytest
• ct-bump-python-version
• ct-bump-viral-baseimage-0.2.4
• ct-gh-actions-jvm-heap-decrease
• ct-ghactions-update-ubuntu
• ct-github-actions
• ct-help-text-correction
• ct-option-to-include-dup-reads-in-filtering
• ct-set-default-threads
• ct-swiftseq-demux-integration
• ct-update-baseimage
• ct-update-docker-base
• ct-update-docker-mem-calc
• ct-update-testing
• ct-version-read-fix
• docs
• dp-conda-fix
• dp-demux
• dp-dev
• dp-docs
• dp-fasta-handling
• dp-fix-fastqc
• dp-novaseq-x-detection
• dp-parser-fixes
• fix-merge-queue-docker-tags
• gh-readonly-queue/master/pr-138-0a38daec5fad0e49d61ea47debfe6dc1db170818
• gh-readonly-queue/master/pr-141-6dccb557c0b87dbb18f0866f0df7640ff8ec61d3
• ll-add_swiftseq_demux
• master
• v2.2.0
• v2.2.1
• v2.2.3
• v2.3.0
• v2.3.1
• v2.3.2
• v2.3.3
• v2.3.4
• v2.3.5
• v2.3.6
• v2.4.0
• v2.4.1
• v2.4.2
• v2.4.3
• v2.5.0
• v2.5.1
• v2.5.10
• v2.5.2
• v2.5.3
• v2.5.4
• v2.5.5
• v2.5.6
• v2.5.7
• v2.5.8
• v2.5.9

Build # 19769443323

Build Type

Pull #140

github

Committed by dpark01

Commit Message

Add append_run_id support to splitcode_demux_fastqs

Fixes #139: Output BAM filenames now use proper library name format
for SRA submission compatibility.

Changes:
- Add --append_run_id flag to include flowcell.lane in BAM filenames
- Fix bug: BAM filenames now use sample_library_id (from 'run' column)
  instead of sample_name, ensuring library_id_per_sample is included
- Without flag: {sample}.l{library_id}.bam (e.g., H2O.l1.bam)
- With flag: {sample}.l{library_id}.{flowcell}.{lane}.bam
  (e.g., H2O.l1.HKWJJDSX7.1.bam)

This affects both 2-barcode and 3-barcode code paths. The SampleSheet
class already builds the correct 'run' field format, so the fix
leverages existing functionality rather than duplicating logic.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Pull Request Pull Request #140: Add append_run_id support to splitcode_demux_fastqs and make lane optional

Run Details

10 of 11 new or added lines in 1 file covered. (90.91%)

4182 of 6043 relevant lines covered (69.2%)

0.69 hits per line