MushroomObserver / mushroom-observer / 28751530117

99%

main: 99%

Build Type

Pull #4688

github

Committed by nimmolo

Commit Message

Close remaining User.current reads in controllers/views; drop cop exemptions

The NoUserCurrentInViews cop only covered app/controllers and
app/components, and its matcher missed the ::User.current cbase-qualified
form and never flagged =~/comparison operators correctly (its assignment
guard misfired on == too, since == also ends with "="). That let three
real reads through: Map#location_format_value's ::User.current_location_format
fallback, Form::LocationHelp#scientific?, and
Projects::FieldSlips::New#member?, plus a genuine read in
ApplicationController::Authentication#update_sudo_session.

Extended the cop's Include to app/views, fixed the matcher to catch
::User.current too, and removed the fixed-arity assignment guard (dead
code - the pattern's 2-child shape already can't match a 3-child
assignment send). Replaced every flagged read with @user / current_user
(the registered Phlex value helper) instead. No exemptions remain in
.rubocop.yml - the three previously-excluded controllers no longer need
them since the cop never actually flagged their (legitimate) writes.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #4688: Close remaining User.current reads in controllers/views; drop cop exemptions

Coverage Stats

3 of 4 new or added lines in 4 files covered. (75.0%)

16 existing lines in 3 files now uncovered.

51401 of 52196 relevant lines covered (98.48%)

753.17 hits per line