MushroomObserver / mushroom-observer / 28752114414

99%

main: 99%

Build Type

Pull #4688

github

Committed by nimmolo

Commit Message

set_user_from_session only needs to set @user, not User.current

Verified neither caller (autocompleters_controller, images/originals_controller)
reads User.current anywhere in its request path - no version-saving,
no Image creation, and the shared around_action's IP-stats logging
reads @user, not the global. Setting User.current here was propping
up exactly the ambient-global reliance this cleanup is trying to
remove; a future caller that needs it for a model default should pass
user: explicitly instead.

Fixed test_user_maxed_out, which relied on User.current still holding
the logged-in user after the request returned (broken by the above,
since the shared around_action resets User.current at the start of
every request) - now references the fixture user directly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Pull Request Pull Request #4688: Close remaining User.current reads in controllers/views; drop cop exemptions

Coverage Stats

9 of 10 new or added lines in 7 files covered. (90.0%)

4 existing lines in 1 file now uncovered.

51402 of 52196 relevant lines covered (98.48%)

752.4 hits per line