MushroomObserver / mushroom-observer / 28757345775

99%

main: 99%

Pull #4688

github

Remove User.current from controller and integration tests

Extends MushroomObserver/NoUserCurrentInViews to test/controllers,
test/views, test/integration, test/system, test/mailers,
test/components, and the shared *_test_case.rb/*_extensions.rb files,
then fixes every offense the wider net turned up:

- Controller tests read the controller's own current_user (set by a
  real request dispatch) or the fixture already known to be logged in,
  instead of the thread-local global.
- Admin::SessionControllerTest's three assertions taken right after
  login (before any request dispatch) check session[:user_id] instead,
  since current_user isn't set until autologin's before_action runs.
- Capybara integration tests get a shared rack_session helper
  (CapybaraSessionExtensions) that reads the real server-side session
  hash via the rack_test driver, preserving the "did the switch
  actually happen server-side" check rather than just trusting
  rendered banner text.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

9 of 13 new or added lines in 7 files covered. (69.23%)

51503 of 52266 relevant lines covered (98.54%)

748.58 hits per line