ICRAR / ngas

69%

master: 69%

LAST BUILD ON BRANCH small-improvements

branch: small-improvements

CHANGE BRANCH

x

Reset

• small-improvements
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• clone-order-fixes
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Build # 407

Build Type

push

travis-ci

Committed by rtobar

Commit Message

Remove imp-based locking

In python 3.8 we are now actually getting warnings due to the imp module
getting eventually removed. We new its usage was discouraged, but now we
are really being told in the face we should stop using it.

It turns out this was actually a symptom that we were not doing things
right the begin with: importlib.import_module already checks for
sys.modules as a shortcut, and while it was possible for us to do this
check this separately in a safe manner using the imp module, it's not
possible to do safely without imp; the proper way of doing this then is
*always* calling import_module. This actually greatly simplifies the
code, and makes it stronger against multi-threading race conditions in
python 3.3+.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

13326 of 19433 relevant lines covered (68.57%)

4.78 hits per line