ICRAR / ngas

70%

master: 69%

LAST BUILD ON BRANCH uwe-fixes

branch: uwe-fixes

CHANGE BRANCH

x

Reset

• uwe-fixes
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• clone-order-fixes
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• v11
• v12
• v12.0
• various_improvements
• volumes

Ensure python 3 compatibility

The ngasCheckFileCopies tool wasn't ready for python 3, as it relied on
dict.keys() returning a list, which was then sorted. Since these lists
were short-lived we are better off using the sorted() builtin though,
which takes any iterable as input.

While doing this I realised some comments in the code didn't make sense,
so I changed them slightly. While testing I also found problems with the
calculation of the file lists, which apparently includes all files from
all disks. These two facts, plus other details (the logging
configuration being fixed at module import time, for instance) suggest
that a rewriting of this tool would not be a bad idea.

This addresses the original problem raised in #95.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>