ICRAR / ngas

65%

master: 69%

LAST BUILD ON BRANCH clone-order-fixes

branch: clone-order-fixes

CHANGE BRANCH

x

Reset

• clone-order-fixes
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Build # 296

Build Type

push

travis-ci

Committed by rtobar

Commit Message

Using explicit order to get cloning candidates

Unit tests were sometimes failing against PostgreSQL because part of the
cloning logic relied on taking the first element from an unordered
query. It was clear from the reference files that the expected behavior
was to use the lowest version of a file in these opportunities, so I've
added a new ordering option to getFileInfoFromFileId to cater for this
specific order, and started using it from the CLONE command.

After these changes all tests pass with SQLite, and therefore I'm
assuming they will happily run against the other DB engines too.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

12525 of 19168 relevant lines covered (65.34%)

4.56 hits per line