ICRAR / ngas
69%
master: 69%

LAST BUILD BRANCH: config_use_prepared_stmts_for_clients
DEFAULT BRANCH: master
Repo Added
Files 165
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH issue-50
branch: issue-50
CHANGE BRANCH
x

525

push

travis-ci-com

Rodrigo Tobar 
Address problems found during testing

Stewart tried out the latest changes to the subscription logic and found
three different problems, all of which are addressed in this commit.

Firstly, a typo in the email message has been fixed. Secondly, a logging
statement was missing a value for a format specifier. These two changes
were minor.

Finally, and most importantly, when a subscription fails to be added
because a similar-looking one already exists, the code tried to remove
the subscription object twice from the list of yet-to-be-created
subscriptions, which raised an unexpected error. However, at the same
time Stewart pointed out that at server shutdown the subscription that
wasn't added *was* removed from the remote server, which is what he
expected to see. This is not exactly great (if we are not adding it we
shouldn't be removing it), but on the other hand I see the appeal on
doing so, and since they are the main users of this feature anyway I'll
follow their preference. To avoid the double removal of the object,
while keeping the code path separate from the fully successful cases, I
created a small function that centralises the marking of a subscription
as active on the local server so it gets removed when the server goes
down.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

7 of 7 new or added lines in 1 file covered. (100.0%)

13656 of 19755 relevant lines covered (69.13%)

4.13 hits per line

Relevant lines Covered
19755 RELEVANT LINES 13656 COVERED LINES
4.13 HITS PER LINE
Source Files on issue-50

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
525 issue-50 Address problems found during testing Stewart tried out the latest changes to the subscription logic and found three different problems, all of which are addressed in this commit. Firstly, a typo in the email message has been fixed. Secondly, a ... push Rodrigo Tobar travis-ci-com pending completion  
524 issue-50 Handle existing subscriptions on server startup Now that the SUBSCRIBE command lets us know if a subscription already exists or not on the remote end, we can do things differently at server startup to avoid continuous errors being thrown at us. ... push Rodrigo Tobar travis-ci-com pending completion  
523 issue-50 Notify clients when subscription exists This change is the core of #50: it checks if a subscription for the given ID exists or not before attempting insertion. If one exists, the server replies to the client with different HTTP codes depending on... push Rodrigo Tobar travis-ci-com pending completion  
522 issue-50 Notify clients when subscription exists This change is the core of #50: it checks if a subscription for the given ID exists or not before attempting insertion. If one exists, the server replies to the client with different HTTP codes depending on... push Rodrigo Tobar travis-ci-com pending completion  
521 issue-50 Notify clients when subscription exists This change is the core of #50: it checks if a subscription for the given ID exists or not before attempting insertion. If one exists, the server replies to the client with different HTTP codes depending on... push Rodrigo Tobar travis-ci-com pending completion  
See All Builds (534)