ICRAR / ngas

69%

master: 69%

LAST BUILD ON BRANCH NGAS-163

branch: NGAS-163

CHANGE BRANCH

x

Reset

• NGAS-163
• 98-query-ignore
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• clone-order-fixes
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Return 411 when on invalid/missing Content-Length

As stated in NGAS-163, NGAS should respond with 411 rather than 400 when
requests with no Content-Length (or Content-Length=0) arrive, as the
codebase currently expects a Content-Length to be given.

To keep things consistent, instead of sending the response back directly
where the problem is identified, we instead simply raise a typed error,
which we then handle more centrally with the rest of the known errors.

The unit test checking that zero-length files cannot be archived has
been updated to double-check the HTTP status from the failing request.
Adding this check also made part of test_QArchive obsolete and
duplicate (it does exactly the same that test_FileSizeZero does), so I
removed the duplicate.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>