ICRAR / ngas

69%

master: 69%

LAST BUILD ON BRANCH issue-13

branch: issue-13

CHANGE BRANCH

x

Reset

• issue-13
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• clone-order-fixes
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Generate useful message upon unknown MIME type

As pointed out by #13, issuing an archiving command with an unknown MIME
type currently results on a cryptic, internal error message ("'NoneType'
object has no attribute 'getHostIdList'") rather than a useful one.

This commit avoids the condition that generated the previous error
message, adding the necessary checks to generate a more meaningful error
message instead stating that the MIME type is not konwn to NGAS.
Alongside this change I also slightly simplified a bit of code to avoid
some small repetitions.

A new unit test also ensures the error message received by the user is
actually useful. This is done by checking that the unknown MIME type
sent by the user is somewhere in the error message, hinting that the
issue is being addressed by the message.