ICRAR / ngas

67%

master: 69%

LAST BUILD ON BRANCH clone-fix

branch: clone-fix

CHANGE BRANCH

x

Reset

• clone-fix
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-order-fixes
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Build # 300

Build Type

push

travis-ci

Committed by rtobar

Commit Message

Proper order of candidates for cloning, take 2

This new implementation orders the results the *correct* way; that is,
by descending file ID first, and by disk **label** later. The original
behavior (that used when order=1 is given) orders by disk *ID*, but main
disks cannot be expected to have lower IDs than replica disks.

Our previous attempt to fix things was obviously wrong, as the intended
behavior in the case of only a file ID being specified for cloning has
always been to clone the latest version of that file rather than the
first, just like the rest of the commands assume the same.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

12889 of 19168 relevant lines covered (67.24%)

4.69 hits per line