ICRAR / ngas

70%

master: 69%

LAST BUILD ON BRANCH correct-janitor-init

branch: correct-janitor-init

CHANGE BRANCH

x

Reset

• correct-janitor-init
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• clone-order-fixes
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• relaxed-netifaces
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Start communication thread before janitor process

The main server process and the janitor process communicate through a
pair of Queues. The handling of this communication on the main server
process happens on a separate thread, which we used to start after we
spawned the janitor process. This sequence opened the door for a race
condition where the janitor process would try to read from the
corresponding queue, but the main server wouldn't have put any item on
it yet as the communication thread wouldn't have started yet.

This commit fixes this situation by starting the communication thread
before spawning the janitor process. Since we are not waiting for the
communication thread to be up and running (only starting it) there is
still some chance that the original problem could occur, but with a much
lesser probability.

This addresses the problem originally reported in #78.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>