ICRAR / ngas

67%

master: 69%

LAST BUILD ON BRANCH relaxed-netifaces

branch: relaxed-netifaces

CHANGE BRANCH

x

Reset

• relaxed-netifaces
• 98-query-ignore
• NGAS-163
• aiosmtpd
• avoid-installing-bsddb3-in-py27
• bbcp_fixes
• c_client_warning_fixes
• centos7-compatibility-changes
• clone-fix
• clone-order-fixes
• correct-janitor-init
• correct-logging-c
• coverage-stability
• direct_sql
• doc-updates
• docs-fix
• document-future-removal-of-27
• fits_optional_arcfile
• fix-requests-dependency-specs
• fs-monitor
• fs-monitor-fixes
• github-actions
• improve-register-error-message
• issue-103
• issue-13
• issue-38
• issue-44
• issue-50
• issue-51
• janitor-thread-startup
• macos-hostnames
• macos-travis-fix
• macos-travis-update
• master
• netifaces-fix
• next
• no-create-venv
• none-reg-parameters
• partner_sites
• plugins-importing
• py311
• py39
• python-client-improvements
• release-12.0
• remove-2.7-builds
• remove-test-generic-registration-plugin
• requests-pinning
• richer-archiving-event
• separate-test-servers
• servers-flag
• small-improvements
• smtp-testing
• stream-proxy-request
• subscription-def
• subscription_thread_ng
• travis-errors
• travis-fixes
• travis-focal
• update-travis-matrix
• uwe-fixes
• v11
• v12
• v12.0
• various_improvements
• volumes

Build # 335

Build Type

push

travis-ci

Committed by rtobar

Commit Message

Relax constraint on netifaces

The features we need from netifaces have probably been there from the
very beginning. Our dependency on a particular version is more something
of an internal baggage: while working for a different project we
contributed a patch to netifaces to help *building* it in old Linux
boxes. This patch was included in netifaces version 10.6. Since then, we
had our other project depend on >=10.6, and when we introduced this
dependency on NGAS we blindly copied it over.

Stewart Mclay pointed this out when he started trying out NGAS 11.0.2 in
his CentOS environment, which ships a system python-netifaces package
version 10.4. Functionality-wise this is more than enough for us, and
only then it became clear that the constraint was an overshot.

If any deployment breaks due to this then what needs to be fixed is the
deployment instructions, not NGAS itself, as it's the deployment's
responsibility to make sure there is a consistent environment to deploy
NGAS into.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

12907 of 19170 relevant lines covered (67.33%)

4.69 hits per line