407
69%
master: 69%

Ran 13 Feb 2020 06:45AM UTC

Jobs 7

Files 163

Run time 12min

Badge

Embed ▾

pending completion

Build # 407

Build Type

push

travis-ci

Committed by

rtobar

Commit Message

Remove imp-based locking

In python 3.8 we are now actually getting warnings due to the imp module
getting eventually removed. We new its usage was discouraged, but now we
are really being told in the face we should stop using it.

It turns out this was actually a symptom that we were not doing things
right the begin with: importlib.import_module already checks for
sys.modules as a shortcut, and while it was possible for us to do this
check this separately in a safe manner using the imp module, it's not
possible to do safely without imp; the proper way of doing this then is
*always* calling import_module. This actually greatly simplifies the
code, and makes it stronger against multi-threading race conditions in
python 3.3+.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

Run Details

13326 of 19433 relevant lines covered (68.57%)

4.78 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	407.1 (DB=sqlite3)	13 Feb 2020 06:45AM UTC	163	68.18	Travis Job 407.1
2	407.2 (DB=mysql)	13 Feb 2020 06:46AM UTC	163	68.31	Travis Job 407.2
3	407.3 (DB=postgresql)	13 Feb 2020 06:46AM UTC	163	68.27	Travis Job 407.3
4	407.4	13 Feb 2020 06:57AM UTC	163	68.25	Travis Job 407.4
5	407.5	13 Feb 2020 06:45AM UTC	163	68.21	Travis Job 407.5
6	407.6	13 Feb 2020 06:57AM UTC	163	68.35	Travis Job 407.6
7	407.7	13 Feb 2020 06:56AM UTC	163	68.18	Travis Job 407.7

ICRAR / ngas / 407
69%
master: 69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 407

ICRAR / ngas / 407 69% master: 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 407

ICRAR / ngas / 407
69%
master: 69%

README BADGES
x