source-academy / frontend / 8937138713

40%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate to Redux Toolkit part 7 (#2971)

* Migrate `evalStory` handler to Stories Saga

* Add Redux utils

Originally done in f1cf593ac.

Amended to fix some bugs with types.

---------

Co-authored-by: Lee Yi <leeyi45@gmail.com>

* Migrate some stories actions to use helper

Type errors will be fixed later.

* Migrate more stories actions to use helper

* Fix old reducer/actions helper compatibility issues

* Migrate new stories users handler to BackendSaga

Done to align with where the action creator is located.

* Migrate StoriesSaga to use helper

Original implementation in bbf4f090e.

Adapted to match current state of codebase.

---------

Co-authored-by: Lee Yi <leeyi45@gmail.com>

* Fix tests

* Fix compile errors

Also added a TODO for a testing util.

* Remove unnecessary rootReducer creator

* Fix combineSagaHandlers

* Migrate SessionActions to use helper

Some are left unmigrated to preserve the readability of the diff.

* Remove old session types

* Update tests and non-related sagas

Only updated sagas that require a simple fix of the imported action
types. Remaining sagas will be done in a later commit.

* Fix SessionActions compatibility with ActionsHelper

* Comment out most of mock backend saga

To minimise potentially unnecessary development effort while pending
removal decision outcome. Only commented handlers that are incompatible
with the type changes.

* Fix SessionReducer tests

* Use action creator in components

Use the action creator instead of creating the action object manually to
enforce abstraction.

* Migrate BackendSaga to use new helpers

Intentionally done in a very specific way, mixing new and old code
styles, in order to keep the diff legible for such a large migration.
Further refactoring will be done in the future.

* Update backend saga tests

* Remove duplicate action types... (continued)

Run Details

1919 of 6894 branches covered (27.84%)

Branch coverage included in aggregate %.

196 of 423 new or added lines in 13 files covered. (46.34%)

5 existing lines in 1 file now uncovered.

5146 of 14691 relevant lines covered (35.03%)

20.98 hits per line