source-academy / frontend / 5688012768

40%

Build Type

push

github

Committed by web-flow

Commit Message

Fix new story screen, refactor stories state logic and component (#2573)

* Refactor story types

Creates a generic story data type that views can inherit from.

* Create separate current story ID state variable

Also makes a change to reduce the number of properties in the current
story state.

* Create set current story ID action and types

* Update action creator signatures

* Update default story content variable name

* Further split StoryData into data and metadata

* Handle setting of current story ID in StoriesSaga

* Add explanatory comment

* Update Story component logic

Fixes blank screen on new story.

* Remove unneeded newlines

Improves code readability.

* Migrate scroll sync to separate function

* Improves code readability
* Improves separation of concerns

Run Details

2047 of 6668 branches covered (30.7%)

Branch coverage included in aggregate %.

8 of 30 new or added lines in 5 files covered. (26.67%)

1 existing line in 1 file now uncovered.

5474 of 14246 relevant lines covered (38.42%)

18.09 hits per line