source-academy / frontend / 8971758895

40%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor Academy router (#2978)

* Reformat router config

Aligning the paths to the left and the elements to the right improves
code readability.

* Refactor homepage redirect to use loader

* Use new splat paths logic

To ease future migration.

* Create guarded route class

* Migrate Academy routes to data loader API

* Use Outlet in Academy container component
* Define Academy routes in separate file
* Replace some logic with loaders
* Use relative paths to match v7 splat paths behavior
* Use guarded route where possible
* Refactor dynamic routing logic for assessment configurations
* Update app router config when assessment configurations change

Also refactored "not found" behavior:

* Only show not found page in "/not_found" route
* Redirect all not found routes to "/not_found"

* Use lazy loading for Academy routes

* Update tests

* Fix tests

* Address comments

* Remove unnecessary `useEffect` dependency

* Refactor `ensureUserAndRole` to use route guard

* Remove now-unnecessary router dependency on role

In the future, the goal is to never have to update the application
router.

* Revert dependency injection for assessmentConfigurations

Now, the store is accessed directly inside the loader. This fixes an
infinite rerendering problem on admin panel.

* Remove outdated comment about disabled SA

* Fix format

* Restore old 404 behavior

---------

Co-authored-by: En Rong <53928333+chownces@users.noreply.github.com>

Run Details

1921 of 6901 branches covered (27.84%)

Branch coverage included in aggregate %.

22 of 116 new or added lines in 20 files covered. (18.97%)

3 existing lines in 2 files now uncovered.

5004 of 14643 relevant lines covered (34.17%)

20.91 hits per line