spesmilo / electrum
64%
master: 66%

LAST BUILD BRANCH: new_storage_api
DEFAULT BRANCH: master
Repo Added
Files 87
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 202603_rpc_password_not_empty
branch: 202603_rpc_password_not_empty
CHANGE BRANCH
x

coverage: 63.821% (-1.0%) from 64.837%
4878708437155840

Pull #10534

CirrusCI

SomberNight 
daemon: forbid "setconfig" command to change rpcserver settings in-flight

It is much easier to reason about the rpcserver if we don't allow changing its basic settings while it is already running. What does it mean to change the TCP port it is listening on ("rpcport") if it's already running? It is even problematic to change the rpcpassword: care needs to be taken to already update it for the current server.
(ref https://github.com/spesmilo/electrum/issues/6762)

This commit disallows changing all of the "rpc*" config variables if the daemon is already running.

---

Simultaneously, it also ensures rpc_password is always set and auth cannot be disabled.

Previously if there was a daemon running, and the user ran
`$ electrum setconfig rpcpassword ""` that would leave the RPC unauthenticated
for the current session. However next time the daemon restarted, get_rpc_credentials would see
the unset password and generate one.

I think this was the worst of both worlds:
- we did not really allow removing the rpc password, except for the current session, and
- perhaps unexpectedly, we would generate a new password on daemon restart

Instead now we explicitly make sure the RPC server can never get into a state where it does not have a password set.

Based on a report by `Zuzana Kotásková <36777@mail.vsfs.cz>`
Pull Request #10534: daemon: forbid "setconfig" command to change rpcserver settings in-flight

0 of 4 new or added lines in 2 files covered. (0.0%)

757 existing lines in 14 files now uncovered.

24568 of 38495 relevant lines covered (63.82%)

0.64 hits per line

Relevant lines Covered
38495 RELEVANT LINES 24568 COVERED LINES
0.64 HITS PER LINE
Source Files on 202603_rpc_password_not_empty

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
48787084... 202603_rpc_password_not_empty daemon: forbid "setconfig" command to change rpcserver settings in-flight It is much easier to reason about the rpcserver if we don't allow changing its basic settings while it is already running. What does it mean to change the TCP port it is li... Pull #10534 SomberNight CirrusCI
63.82
61249824... 202603_rpc_password_not_empty daemon: ensure rpc_password is always set and auth cannot be disabled Previously if there was a daemon running, and the user ran `$ electrum setconfig rpcpassword ""` that would leave the RPC unauthenticated for the current session. However next ... Pull #10534 SomberNight CirrusCI
63.82
See All Builds (13530)