spesmilo / electrum
61%
master: 61%

Repo Added 10 Nov 2017 08:46AM UTC

Committed 11 Apr 2025 12:04PM UTC coverage: 60.928% (+0.6%) from 60.28%

Committed by

Commit Message

Fix assertion error in ln payments when using same seed in multiple wallets.

Make path calculation check if channel is not in our sending channels but still uses our nodeID as starting node of the path.

I noticed an assertion error when trying to pay an invoice from a seed i have opened channels with in different wallet instances (same seed, different wallet).
Because the channel seemed suitable for sending the payment path finding included the channel for sending in the first position of the route but then
in pay_to_route the channel for route[0] could not be found as it is not included in our channel list, causing the assert and payment to fail.

4 of 5 new or added lines in 1 file covered. (80.0%)

337 existing lines in 6 files now uncovered.

21421 of 35158 relevant lines covered (60.93%)

2.44 hits per line

35158 RELEVANT LINES 21421 COVERED LINES

2.44 HITS PER LINE

Builds	Branch	Commit	Type	Ran	Committer	Via	Coverage
63809755...	lightning_pay_assertion_error	Fix assertion error in ln payments when using same seed in multiple wallets. Make path calculation check if channel is not in our sending channels but still uses our nodeID as starting node of the path. I noticed an assertion error when trying t...	Pull #9723	11 Apr 2025 12:11PM UTC	f321x	CirrusCI	60.93
46210345...	lightning_pay_assertion_error	Fix assertion error in ln payments when using same seed in multiple wallets. Make path calculation check if channel is not in our sending channels but still uses our nodeID as starting node of the path. I noticed an assertion error when trying t...	Pull #9723	11 Apr 2025 11:58AM UTC	f321x	CirrusCI	60.92
64188096...	lightning_pay_assertion_error	Fix assertion error in ln payments when using same seed in multiple wallets. Make path calculation check if channel is not in our sending channels but still uses our nodeID as starting node of the path. I noticed an assertion error when trying t...	Pull #9723	11 Apr 2025 10:30AM UTC	f321x	CirrusCI	60.93
56117083...	lightning_pay_assertion_error	Fix assertion error in ln payments when using same seed in multiple wallets. Make path calculation check if channel is not in our sending channels but still uses our nodeID as starting node of the path. I noticed an assertion error when trying t...	Pull #9723	11 Apr 2025 07:29AM UTC	f321x	CirrusCI	60.96
67160555...	lightning_pay_assertion_error	check if channel is not in our sending channels but still uses our nodeID as starting node of the channel in the path calculation. I noticed an assertion error when trying to pay an invoice from a seed i have opened channels with in different wall...	Pull #9723	10 Apr 2025 02:00PM UTC	f321x	CirrusCI	60.93

spesmilo / electrum
61%
master: 61%

spesmilo / electrum 61% master: 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

CHANGE BRANCH x

Relevant lines Covered

Source Files on lightning_pay_assertion_error

Recent builds

spesmilo / electrum
61%
master: 61%

README BADGES
x

CHANGE BRANCH
x