• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

spesmilo / electrum / 4878708437155840
64%
master: 66%

Build:
Build:
LAST BUILD BRANCH: new_storage_api
DEFAULT BRANCH: master
Ran 24 Mar 2026 05:22PM UTC
Jobs 1
Files 89
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Mar 2026 05:07PM UTC coverage: 63.821% (-1.0%) from 64.837%
4878708437155840

Pull #10534

CirrusCI

SomberNight
daemon: forbid "setconfig" command to change rpcserver settings in-flight

It is much easier to reason about the rpcserver if we don't allow changing its basic settings while it is already running. What does it mean to change the TCP port it is listening on ("rpcport") if it's already running? It is even problematic to change the rpcpassword: care needs to be taken to already update it for the current server.
(ref https://github.com/spesmilo/electrum/issues/6762)

This commit disallows changing all of the "rpc*" config variables if the daemon is already running.

---

Simultaneously, it also ensures rpc_password is always set and auth cannot be disabled.

Previously if there was a daemon running, and the user ran
`$ electrum setconfig rpcpassword ""` that would leave the RPC unauthenticated
for the current session. However next time the daemon restarted, get_rpc_credentials would see
the unset password and generate one.

I think this was the worst of both worlds:
- we did not really allow removing the rpc password, except for the current session, and
- perhaps unexpectedly, we would generate a new password on daemon restart

Instead now we explicitly make sure the RPC server can never get into a state where it does not have a password set.

Based on a report by `Zuzana Kotásková <36777@mail.vsfs.cz>`
Pull Request #10534: daemon: forbid "setconfig" command to change rpcserver settings in-flight

0 of 4 new or added lines in 2 files covered. (0.0%)

757 existing lines in 14 files now uncovered.

24568 of 38495 relevant lines covered (63.82%)

0.64 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
49.54
0.08% electrum/commands.py
2
46.56
0.0% electrum/daemon.py

Coverage Regressions

Lines Coverage ∆ File
321
70.54
-0.06% electrum/wallet.py
174
59.63
-3.89% electrum/payment_identifier.py
60
14.29
2.52% electrum/pem.py
39
71.69
-1.77% electrum/x509.py
36
77.93
-0.16% electrum/invoices.py
28
52.69
0.31% electrum/lnwatcher.py
28
68.88
0.2% electrum/wizard.py
27
60.59
-1.32% electrum/interface.py
24
94.46
-0.34% electrum/lnonion.py
10
92.23
0.48% electrum/trampoline.py
7
87.09
-0.11% electrum/address_synchronizer.py
1
61.29
0.0% electrum/lnworker.py
1
68.41
-0.25% electrum/onion_message.py
1
67.04
-0.07% electrum/util.py
Jobs
ID Job ID Ran Files Coverage
1 4878708437155840.1 24 Mar 2026 05:22PM UTC 89
63.82
Source Files on build 4878708437155840
  • Tree
  • List 89
  • Changed 17
  • Source Changed 0
  • Coverage Changed 17
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Build #48787084...
  • Pull Request #10534
  • PR Base - master (#52201106...)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc