spesmilo / electrum
60%
master: 61%

LAST BUILD BRANCH: refactor_htlc_handling
DEFAULT BRANCH: master
Repo Added
Files 88
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH debug_ln_payment_failure
branch: debug_ln_payment_failure
CHANGE BRANCH
x

coverage: 59.739% (+0.01%) from 59.727%
5284143254208512

Pull #9753

CirrusCI

f321x 
suggest_splits: don't exclude single part configs for too small multi
part configs

I noticed certain ln payments become very unreliable. These payments are ~21k sat, from gossip to gossip sender, with direct, unannounced channel.

Due to the recent fix https://github.com/spesmilo/electrum/pull/9723 `LNPathFinder.get_shortest_path_hops()` will not use channels for the last hop of a route anymore that aren't also passed to it in `my_sending_channels`:

```python
if edge_startnode == nodeA and my_sending_channels:  # payment outgoing, on our channel
    if edge_channel_id not in my_sending_channels:
        continue
```

Conceptually this makes sense as we only want to send through `my_sending_channels`, however if the only channel between us and the receiver is a direct channel that we got from the r_tag and it's not passed in `my_sending_channel` it's not able to construct a route now.

Previously this type of payment worked as `get_shortest_path_hops()` knew of the direct channel between us and `nodeB` from the invoices r_tag and then just used this channel as the route, even though it was (often) not contained in `my_sending_channels`.

`my_sending_channels`, passed in `LNWallet.create_routes_for_payment()` is either a single channel or all our channels, depending on `is_multichan_mpp`:

```python
for sc in split_configurations:
	  is_multichan_mpp = len(sc.config.items()) > 1
```

This causes the unreliable, random behavior as `LNWallet.suggest_splits()` is supposed to `exclude_single_part_payments` if the amount is > `MPP_SPLIT_PART_MINAMT_SAT` (5000 sat).
As `mpp_split.py suggest_splits()` is selecting channels randomly, and then removes single part configs, it sometimes doesn't return a single configuration, as it removes single part splits, and also removes multi part splits if a part is below 10 000 sat:

```python
if target_parts > 1 and config.is_any_amount_smaller_than_min_part_size():
    continue
```

This will result in a fallback to all... (continued)
Pull Request #9753: ln: don't exclude single part configs for too small payments

7 of 7 new or added lines in 2 files covered. (100.0%)

336 existing lines in 3 files now uncovered.

21540 of 36057 relevant lines covered (59.74%)

2.98 hits per line

Relevant lines Covered
36057 RELEVANT LINES 21540 COVERED LINES
2.98 HITS PER LINE
Source Files on debug_ln_payment_failure

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
52841432... debug_ln_payment_failure suggest_splits: don't exclude single part configs for too small multi part configs I noticed certain ln payments become very unreliable. These payments are ~21k sat, from gossip to gossip sender, with direct, unannounced channel. Due to the rece... Pull #9753 f321x CirrusCI
59.74
57819974... debug_ln_payment_failure suggest_splits: don't exclude single part configs for too small multi part configs I noticed certain ln payments become very unreliable. These payments are ~21k sat, from gossip to gossip sender, with direct, unannounced channel. Due to the rece... Pull #9753 f321x CirrusCI
59.74
55191021... debug_ln_payment_failure suggest_splits: don't exclude single part configs for too small multi part configs I noticed certain ln payments become very unreliable. These payments are ~21k sat, from gossip to gossip sender, with direct, unannounced channel. Due to the rece... Pull #9753 f321x CirrusCI
59.73
64385208... debug_ln_payment_failure suggest_splits: don't exclude single part configs for too small multi part configs I noticed certain ln payments become very unreliable. These payments are ~21k sat, from gossip to gossip sender, with direct, unannounced channel. Due to the rece... Pull #9753 f321x CirrusCI
59.73
60968817... debug_ln_payment_failure suggest_splits: don't exclude single part configs for too small multi part configs I noticed certain ln payments become very unreliable. These payments are ~21k sat, from gossip to gossip sender, with direct, unannounced channel. Due to the rece... Pull #9753 f321x CirrusCI
60.31
See All Builds (12275)