spesmilo / electrum
62%
master: 63%

LAST BUILD BRANCH: 202601_qml_open_passwordless_wallets
DEFAULT BRANCH: master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix_channel_removal_assert
branch: fix_channel_removal_assert
CHANGE BRANCH
x

coverage: 62.379% (+0.003%) from 62.376%
5759379720372224

Pull #10346

CirrusCI

f321x 
lnchannel: allow deleting unfunded incoming channels

We tried to delete incoming channels that didn't get funded after
lnutil.CHANNEL_OPENING_TIMEOUT, however an assert prevented this:

```
  3.63 | E | lnwatcher.LNWatcher.[default_wallet-LNW] | Exception in check_onchain_situation: AssertionError()
Traceback (most recent call last):
  File "/home/user/code/electrum-fork/electrum/util.py", line 1233, in wrapper
    return await func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/code/electrum-fork/electrum/lnwatcher.py", line 117, in check_onchain_situation
    await self.update_channel_state(
    ...<5 lines>...
        keep_watching=keep_watching)
  File "/home/user/code/electrum-fork/electrum/lnwatcher.py", line 135, in update_channel_state
    chan.update_onchain_state(
    ~~~~~~~~~~~~~~~~~~~~~~~~~^
        funding_txid=funding_txid,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<2 lines>...
        closing_height=closing_height,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        keep_watching=keep_watching)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/code/electrum-fork/electrum/lnchannel.py", line 341, in update_onchain_state
    self.update_unfunded_state()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/user/code/electrum-fork/electrum/lnchannel.py", line 382, in update_unfunded_state
    self.lnworker.remove_channel(self.channel_id)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/user/code/electrum-fork/electrum/lnworker.py", line 3244, in remove_channel
    assert chan.can_be_deleted()
           ~~~~~~~~~~~~~~~~~~~^^
AssertionError
```
Pull Request #10346: lnchannel: allow deleting unfunded incoming channels

18 of 31 new or added lines in 3 files covered. (58.06%)

2 existing lines in 2 files now uncovered.

23689 of 37976 relevant lines covered (62.38%)

0.62 hits per line

Relevant lines Covered
37976 RELEVANT LINES 23689 COVERED LINES
0.62 HITS PER LINE
Source Files on fix_channel_removal_assert

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
57593797... fix_channel_removal_assert lnchannel: allow deleting unfunded incoming channels We tried to delete incoming channels that didn't get funded after lnutil.CHANNEL_OPENING_TIMEOUT, however an assert prevented this: ``` 3.63 | E | lnwatcher.LNWatcher.[default_wallet-LNW] | ... Pull #10346 f321x CirrusCI
62.38
54999860... fix_channel_removal_assert lnchannel: allow deleting unfunded incoming channels We tried to delete incoming channels that didn't get funded after lnutil.CHANNEL_OPENING_TIMEOUT, however an assert prevented this: ``` 3.63 | E | lnwatcher.LNWatcher.[default_wallet-LNW] | ... Pull #10346 f321x CirrusCI
62.34
52097444... fix_channel_removal_assert lnchannel: allow deleting unfunded incoming channels We tried to delete incoming channels that didn't get funded after lnutil.CHANNEL_OPENING_TIMEOUT, however an assert prevented this: ``` 3.63 | E | lnwatcher.LNWatcher.[default_wallet-LNW] | ... Pull #10346 f321x CirrusCI
62.36
See All Builds (12792)