spesmilo / electrum / 6124982452879360

64%

master: 66%

Build Type

Pull #10534

CirrusCI

Committed by SomberNight

Commit Message

daemon: ensure rpc_password is always set and auth cannot be disabled

Previously if there was a daemon running, and the user ran
`$ electrum setconfig rpcpassword ""` that would leave the RPC unauthenticated
for the current session. However next time the daemon restarted, get_rpc_credentials would see
the unset password and generate one.

I think this was the worst of both worlds:
- we did not really allow removing the rpc password, except for the current session, and
- perhaps unexpectedly, we would generate a new password on daemon restart

Instead now we explicitly make sure the RPC server can never get into a state where it does not have a password set.

Based on a report by `Zuzana Kotásková <36777@mail.vsfs.cz>`

Pull Request Pull Request #10534: daemon: ensure rpc_password is always set and auth cannot be disabled

Coverage Stats

0 of 6 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

24569 of 38499 relevant lines covered (63.82%)

0.64 hits per line