spesmilo / electrum
63%
master: 63%

LAST BUILD BRANCH: qml_create_storage_exc
DEFAULT BRANCH: master
Repo Added
Files 89
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix_wizard_tc_exc+
branch: fix_wizard_tc_exc+
CHANGE BRANCH
x

coverage: 62.808% (+0.002%) from 62.806%
4842418161319936

Pull #10462

CirrusCI

f321x 
wizard: fix exception when loading new tc wallet

I tried to reproduce:
https://github.com/spesmilo/electrum/issues/8815#issuecomment-2094259186
which triggered the following exception for me:

```
Traceback (most recent call last):
  File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 409, in start_new_window
    window = self._create_window_for_wallet(wallet)
  File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 329, in _create_window_for_wallet
    w = ElectrumWindow(self, wallet)
  File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 290, in __init__
    self.load_wallet(wallet)
    ~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/user/code/electrum-fork/electrum/util.py", line 495, in do_profile
    o = func(*args, **kw_args)
  File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 589, in load_wallet
    self.update_recently_opened_menu()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 741, in update_recently_opened_menu
    for i, k in enumerate(recent):
                ~~~~~~~~~^^^^^^^^
TypeError: 'NoneType' object is not iterable
```

This happens because the trustedcoin wallet is loaded outside of
Daemon.load_wallet() so Daemon.update_recently_opened_wallets()
is not getting called and config.RECENTLY:_OPEN_WALLET_FILES is
still None when we try to iterate through it.
As fix i now call update_recently_opened_wallets directy in
Daemon.add_wallet() and additionally handle
RECENTLY_OPEN_WALLET_FILES being None in
ElectrumWindow.update_recently_opened_menu().

My pull request https://github.com/spesmilo/electrum/pull/10121
would have sent this exception to the crash reporter so we
might have noticed it earlier. I think we should not just catch
all exceptions in the wizard like on master as it causes us to
repeatedly miss regressions in the wizard that could be sent to
the crash reporter.
Pull Request #10462: wizard: fix exception when loading new tc wallet

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

24038 of 38272 relevant lines covered (62.81%)

0.63 hits per line

Relevant lines Covered
38272 RELEVANT LINES 24038 COVERED LINES
0.63 HITS PER LINE
Source Files on fix_wizard_tc_exc+

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
48424181... fix_wizard_tc_exc+ wizard: fix exception when loading new tc wallet I tried to reproduce: https://github.com/spesmilo/electrum/issues/8815#issuecomment-2094259186 which triggered the following exception for me: ``` Traceback (most recent call last): File "/home/... Pull #10462 f321x CirrusCI
62.81
See All Builds (12873)