spesmilo / electrum
60%
master: 61%

LAST BUILD BRANCH: refactor_htlc_handling
DEFAULT BRANCH: master
Repo Added
Files 88
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix_too_large_onion_payload
branch: fix_too_large_onion_payload
CHANGE BRANCH
x

coverage: 60.317% (+0.02%) from 60.299%
4800060761833472

Pull #9733

CirrusCI

f321x 
Stop including all invoice r_tags in legacy trampoline onion

This change modifies create_trampoline_onion to only include as many
available r_tags as there is space left in the trampoline onion payload.

Previously we tried to include all passed invoice r_tags of legacy
trampoline payments into the payload which caused an user facing
exception and payment failure as the onion can only store a max of 400
bytes.
A single, single hop r_tag is around 52 bytes and the payload
without r_tags is already at ~280 bytes. So usually there is enough
space for 2 r_tags.
The implementation shuffles the r_tags on each call
so the payment will try different route hints on the attempts (fee level
increase or user retry).

I have logged the following byte sizes of the trampoline onion with a 2
trampoline onion hop and changing amounts of r_tags:

3 rtags:
payload size [0]: 113 (hop size: 81)
payload size [1]: 440 (hop size: 295) ( 52 bytes/rtag )
payload size [2]: 550 (hop size: 78)

2 rtags:
payload size [0]: 113 (hop size: 81)
payload size [1]: 386 (hop size: 241) ( 52 bytes/rtag )
payload size [2]: 496 (hop size: 78)

1 rtag:
payload size [0]: 113 (hop size: 81)
payload size [1]: 334 (hop size: 189) ( 52 bytes/rtag )
payload size [2]: 444 (hop size: 78)

0 rtags:
payload size [0]: 113 (hop size: 81)
payload size [1]: 282 (hop size: 137)
payload size [2]: 392 (hop size: 78)

As can be seen in the data, using 2 trampoline hops there is not enough
space for even a single r_tag which is why this option is being removed
too.
Pull Request #9733: lightning: stop including all invoice r_tags in legacy trampoline onion

27 of 28 new or added lines in 2 files covered. (96.43%)

207 existing lines in 5 files now uncovered.

21602 of 35814 relevant lines covered (60.32%)

3.01 hits per line

Relevant lines Covered
35814 RELEVANT LINES 21602 COVERED LINES
3.01 HITS PER LINE
Source Files on fix_too_large_onion_payload

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
48000607... fix_too_large_onion_payload Stop including all invoice r_tags in legacy trampoline onion This change modifies create_trampoline_onion to only include as many available r_tags as there is space left in the trampoline onion payload. Previously we tried to include all passed ... Pull #9733 f321x CirrusCI
60.32
61244257... fix_too_large_onion_payload Stop including all invoice r_tags in legacy trampoline onion This change modifies create_trampoline_onion to only include as many available r_tags as there is space left in the trampoline onion payload. Previously we tried to include all passed ... Pull #9733 f321x CirrusCI
60.32
48977070... fix_too_large_onion_payload Stop including all invoice r_tags in legacy trampoline onion This change modifies create_trampoline_onion to only include as many available r_tags as there is space left in the trampoline onion payload. Previously we tried to include all passed ... Pull #9733 f321x CirrusCI
60.32
See All Builds (12275)