spesmilo / electrum
60%
master: 61%

LAST BUILD BRANCH: refactor_htlc_handling
DEFAULT BRANCH: master
Repo Added
Files 88
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH 202505_transaction_verify_sig_2
branch: 202505_transaction_verify_sig_2
CHANGE BRANCH
x

coverage: 59.794% (+0.3%) from 59.53%
4993842472026112

Pull #9839

CirrusCI

SomberNight 
transaction: add method verify_sig_for_txin

This new `Transaction.verify_sig_for_txin` function is an instance method of `Transaction` instead of `PartialTransaction`.
It takes a complete txin, a pubkey and a signature, and verifies the signature.

- `get_preimage_script` is renamed to `get_scriptcode_for_sighash` and now effectively has two implementations:
  - the old impl became `PartialTxInput.get_scriptcode_for_sighash`
    - this assumes we are the ones constructing a spending txin and can have knowledge beyond what will be revealed onchain
  - the new impl is in the base class, `TxInput.get_scriptcode_for_sighash`
    - this assumes the txin is already "complete", and mimics a consensus-verifier by extracting the required fields
      from the already complete witness/scriptSig and the scriptpubkey of the funding utxo
- `serialize_preimage` now does not require a PartialTransaction, it also works on the base class Transaction

-----

I intend to use this for debugging only atm: I noticed TxBatcher sometimes creates invalid signatures by seeing
that bitcoind rejects txs with `mandatory-script-verify-flag-failed (Signature must be zero for failed CHECK(MULTI)SIG operation)`.
However the txs in question have multiple txins, with some txins containing multiple signatures, and bitcoind does not tell us
which txin/signature is invalid. Knowing which signature is invalid would be a start, but I can now add some temp debug logging
to `serialize_preimage` to compare the message being signed with the message being verified.

As can be seen from the tests, the signature and the pubkey needs to be manually extracted from the txin to be verified:
we still don't have a script interpreter so we don't have logic to "verify a txin". However this new code adds logic
to verify a signature for a txin/pubkey combo (which is a small part of an interpreter/verifier).
Pull Request #9839: transaction: add method verify_sig_for_txin

156 of 178 new or added lines in 1 file covered. (87.64%)

557 existing lines in 7 files now uncovered.

21631 of 36176 relevant lines covered (59.79%)

2.99 hits per line

Relevant lines Covered
36176 RELEVANT LINES 21631 COVERED LINES
2.99 HITS PER LINE
Source Files on 202505_transaction_verify_sig_2

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
49938424... 202505_transaction_verify_sig_2 transaction: add method verify_sig_for_txin This new `Transaction.verify_sig_for_txin` function is an instance method of `Transaction` instead of `PartialTransaction`. It takes a complete txin, a pubkey and a signature, and verifies the signature... Pull #9839 SomberNight CirrusCI
59.79
See All Builds (12275)