openvax / topiary
92%
master: 92%

LAST BUILD BRANCH: fix-declared-deps-and-dead-surface
DEFAULT BRANCH: master
Repo Added
Files 43
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-cli-coverage-gap-error-handling
branch: fix-cli-coverage-gap-error-handling
CHANGE BRANCH
x

coverage: 92.101% (+0.001%) from 92.1%
34606604640-1

Pull #306

github

iskandr 
CLI catches CachedPredictor's KeyError cleanly (#304)

CachedPredictor raises KeyError, not ValueError, for exactly two
conditions: a peptide the cache doesn't cover with no fallback set, and
a protein-scan occurrence a flank or genotype mismatch leaves uncovered
(#296, #302). main()'s top-level handler only caught
(OSError, ValueError), so this one CachedPredictor failure was the one
that reached the user as a raw Python traceback instead of a clean CLI
error.

main() now catches KeyError too, and unwraps its message rather than
calling str() on it directly - str(KeyError(...)) reprs the message with
an extra quoted layer, which would have made this look different from
every ValueError/OSError message on the same code path.

Deliberately not fixed here: whether a coverage-gap failure during a
multi-sequence batch scan should abort the whole run or skip and report
just the offending occurrence. That's a real design choice with its own
tradeoffs - a partial result that looks complete unless a warning gets
checked is exactly the silent-wrong-answer risk #296/#302 were written
to close, one level up - so #304 stays open for that discussion and
this PR only closes the half that's a straightforward bug.

Claude-Session: https://claude.ai/code/session_015pMD1uiTztbB2bTQ1FkY8m
Pull Request #306: CLI catches CachedPredictor's KeyError cleanly (#304)

4 of 4 new or added lines in 2 files covered. (100.0%)

7101 of 7710 relevant lines covered (92.1%)

0.92 hits per line

Relevant lines Covered
7710 RELEVANT LINES 7101 COVERED LINES
0.92 HITS PER LINE
Source Files on fix-cli-coverage-gap-error-handling

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
34606604... fix-cli-coverage-gap-error-handling CLI catches CachedPredictor's KeyError cleanly (#304) CachedPredictor raises KeyError, not ValueError, for exactly two conditions: a peptide the cache doesn't cover with no fallback set, and a protein-scan occurrence a flank or genotype mismatch ... Pull #306 iskandr github
92.1
See All Builds (542)