MushroomObserver / mushroom-observer / 25959255609

96%

main: 96%

Pull #4269

github

Inline FormNotes help in body; drop heading collapse trigger

Reversed the heading-collapse-trigger approach. Per visual review:
having the help icon in the panel heading was confusing — you
could expand the help block while the panel itself was still
collapsed, so you'd see help text floating above nothing.

New layout (always-visible, no collapse for help):

  - Panel heading: just "Notes" + the panel's own caret. No help
    icon, no `info-collapse-trigger`.
  - Panel body (collapsible by the caret only):
    1. `above_help` prose (single-part mode only)
    2. The textareas (one per part)
    3. Textile-formatting help (always, both modes)

Single-part mode: the prose "what to put in notes" copy lives
above the textarea (where it's the natural reading order), and
the textile-formatting help is below it (where it's reference,
not instruction).

Multi-part mode: just textareas + textile help. No above-help —
users with custom notes parts know what each part is for.

API changes:
- Rename `help_content:` → `above_help:`. The prop is now scoped
  to the single-part above-the-textarea slot (multi-part ignores
  it). FormNotes hardcodes the textile help.
- Revert the `Panel#heading_extras` slot added two commits back —
  no longer needed once the in-heading collapse is gone.

`ObservationForm::NotesPanel#observation_notes_help` →
`observation_above_notes_help`: now returns just the prose Proc
(textile help moved to FormNotes).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

57 of 57 new or added lines in 4 files covered. (100.0%)

38371 of 39782 relevant lines covered (96.45%)

659.05 hits per line