MushroomObserver / mushroom-observer / 25928527606

96%

main: 99%

Pull #4269

github

Move FormNotes help-collapse trigger into the panel heading

Visual review flagged a redundancy in the observation notes panel:
the Bootstrap Panel heading already says "Notes", but the panel
body opened with a `<p><strong>Notes:</strong> <help-trigger> ...</p>`
line — duplicating the title and orphaning the help icon below the
heading.

Move the `CollapseInfoTrigger` (the `?` icon) into the panel's
heading slot, alongside the title, and drop the `<strong>Notes:</strong>`
wrapper from the body. The `CollapseHelpBlock` (the actual collapse
target) stays in the body — trigger and target are decoupled via
`target_id`, so they don't have to be adjacent. (The panel's own
expand/collapse caret is unaffected; the help-trigger is a separate
collapse target.)

Also: derive `help_target_id` from `panel_id` so multiple FormNotes
on the same page can't collide on `notes_help`.

Single-part mode (one large textarea with inline help) is unchanged
— no panel-level trigger; the textarea's `with_help` slot continues
to handle that field's help.

Updates the multi-part FormNotes test to assert the new structure:
trigger lives inside the heading, collapse block in the body, no
`<strong>Notes:</strong>` redundancy.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

66 of 66 new or added lines in 4 files covered. (100.0%)

38374 of 39785 relevant lines covered (96.45%)

661.46 hits per line