MushroomObserver / mushroom-observer / 27115039512

98%

main: 98%

Build Type

Pull #4477

github

Committed by nimmolo

Commit Message

Coverage chase on #4477: cover branches I touched, delete dead method

Branches added or covered:
- new test/controllers/application_controller_test.rb with 9
  tests covering `change_theme_to` (3 branches), `fix_bad_domains`
  GET-on-bad-host redirect, `extra_gc`,
  `default_thumbnail_size` (user-pref vs session fallback), and
  `default_thumbnail_size_set` (user-pref vs session fallback).
  Hosted on `InfoController` so the full filter stack runs.
  Skips `kick_out_excessive_traffic` / `kick_out_robots` /
  `is_cool?` per the per-PR instruction.
- `test_index_advanced_search_success` in images_controller_test:
  covers the `[query, {}]` success return tuple in
  `ImagesController#advanced_search` (existing
  `test_index_advanced_search_error` only hit the rescue path).
- `test_index_project_with_unknown_id_redirects` +
  `test_index_species_list_with_unknown_id_redirects` in
  observations_controller_index_test: cover the
  `find_or_goto_index` bail-outs in
  `ObservationsController::Index#project` and `#species_list`.
- `test_create_success_turbo_stream_renders_update_observation`
  in herbaria_controller_test: covers the turbo_stream branch
  of `HerbariaController#show_modal_flash_or_show_herbarium`
  (two flash_notices + `_update_observation` partial render).

Deleted:
- `HerbariaController#modal_form_action` (dead method — no
  callers anywhere in the codebase; was contributing 3 missed
  coverage lines).

Skipped (require stubbing infra not currently used in MO's
test suite):
- `comments_controller.rb:264` — `@comment.destroy` returning false
- `herbaria_controller.rb:240-242, 259-261` — `@herbarium.save`
  returning false after `validate_herbarium!` passes
- `locations/descriptions_controller.rb:243-244` — the no-change
  branch (existing `test_update_description_no_changes` asserts
  the flash but SimpleCov shows the branch as not taken on the
  description fixtures used)
- `observations_controller/index.rb:82` — defensive raise that
  fires... (continued)

Pull Request Pull Request #4477: Index sort options: hoist to controllers; delete 13 helpers

Coverage Stats

69 of 69 new or added lines in 20 files covered. (100.0%)

29 existing lines in 1 file now uncovered.

45033 of 46159 relevant lines covered (97.56%)

757.2 hits per line