MushroomObserver / mushroom-observer / 27113242579

98%

main: 98%

push

github

check_index_sorting: hoist sort tables to controllers, delete 13 helpers

Refactors the test-infra contract for index-page sort coverage:
each index controller now exposes a public
`index_sort_options` instance method returning the `[[key, label],
...]` tuple table. `GeneralExtensions#check_index_sorting`
reads from `@controller.index_sort_options` after an initial
`get(:index)` (so contextual flips like rss_log can fire). Adds
`assert_each_sort_key_resolves` which checks every sort key
maps to a `Model.order_by_<key>` private method — catches
drift between controllers' tuples and what Query actually
accepts (Query/model dispatcher silently falls back to
`id: :desc` for unknown keys, so a typo would surface as a
secretly-broken dropdown without this check).

Controllers gaining `index_sort_options`:
  ArticlesController, CollectionNumbersController,
  CommentsController, ContributorsController, HerbariaController,
  HerbariumRecordsController, ImagesController,
  LocationsController, Locations::DescriptionsController,
  NamesController, Names::DescriptionsController,
  ObservationsController::Index, ProjectsController,
  SequencesController, SpeciesListsController, UsersController.

Phlex index views drop their inlined `sort_options` private
methods (`comments/index.rb`, `names/index.rb`,
`species_lists/index.rb`) and call `controller.index_sort_options`
instead. ERB index views drop their `helpers.<x>_index_sorts(...)`
calls in favor of `controller.index_sort_options`. The one
cross-controller caller (`observations/species_lists/edit.html.erb`,
which renders the species_lists sort dropdown for a foreign
`@all_lists` query) goes through a class-level cousin
`SpeciesListsController.sort_options(query: ...)`.

Deleted as dead/duplicated:
- 13 `<x>_index_sorts` helper methods (one was inlined as
  `tabs/observations_helper.rb#observations_index_sorts`).
- Helper files that became empty after removing those methods:
  `articles_helper.rb`, `descriptions_h... (continued)

53 of 53 new or added lines in 19 files covered. (100.0%)

45016 of 46163 relevant lines covered (97.52%)

753.98 hits per line