spesmilo / electrum / 6229798680264704
63%
master: 66%

LAST BUILD BRANCH: new_storage_api
DEFAULT BRANCH: master
Ran
Jobs 1
Files 89
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 62.806% (-0.9%) from 63.749%
6229798680264704

Pull #10462

CirrusCI

f321x 
wizard: fix exception when loading new tc wallet

I tried to reproduce:
https://github.com/spesmilo/electrum/issues/8815#issuecomment-2094259186
which triggered the following exception for me:

```
Traceback (most recent call last):
  File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 409, in start_new_window
    window = self._create_window_for_wallet(wallet)
  File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 329, in _create_window_for_wallet
    w = ElectrumWindow(self, wallet)
  File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 290, in __init__
    self.load_wallet(wallet)
    ~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/user/code/electrum-fork/electrum/util.py", line 495, in do_profile
    o = func(*args, **kw_args)
  File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 589, in load_wallet
    self.update_recently_opened_menu()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 741, in update_recently_opened_menu
    for i, k in enumerate(recent):
                ~~~~~~~~~^^^^^^^^
TypeError: 'NoneType' object is not iterable
```

This happens because the trustedcoin wallet is loaded outside of
Daemon.load_wallet() so Daemon.update_recently_opened_wallets()
is not getting called and config.RECENTLY:_OPEN_WALLET_FILES is
still None when we try to iterate through it.
As fix i now use load_wallet() instead of manually
instantiating the Wallet
and additionally handle
RECENTLY_OPEN_WALLET_FILES being None in
ElectrumWindow.update_recently_opened_menu().

My pull request https://github.com/spesmilo/electrum/pull/10121
would have sent this exception to the crash reporter so we
might have noticed it earlier. I think we should not just catch
all exceptions in the wizard like on master as it causes us to
repeatedly miss regressions in the wizard that could be sent to
the crash reporter.
Pull Request #10462: wizard: fix exception when loading new tc wallet

24037 of 38272 relevant lines covered (62.81%)

0.63 hits per line

Coverage Regressions

Lines Coverage ∆ File
380
58.34
 -2.58% electrum/lnworker.py
299
60.97
 -0.96% electrum/lnpeer.py
181
68.33
 -2.86% electrum/wallet.py
132
49.84
 -0.08% electrum/commands.py
68
69.02
 0.14% electrum/wizard.py
67
11.53
 -16.79% electrum/lnsweep.py
37
66.1
 -3.12% electrum/lnchannel.py
31
82.97
 -0.59% electrum/lnaddr.py
29
37.1
 -15.59% electrum/lnwatcher.py
26
83.4
 -3.43% electrum/address_synchronizer.py
14
22.01
 -1.13% electrum/submarine_swaps.py
5
44.46
 -0.91% electrum/exchange_rate.py
5
66.76
 -0.28% electrum/util.py
2
93.27
 -0.5% electrum/lnhtlc.py
1
80.24
 -0.29% electrum/crypto.py
1
46.37
 -0.19% electrum/daemon.py
1
77.46
 -0.47% electrum/invoices.py
1
88.14
 -0.05% electrum/transaction.py
Jobs
ID Job ID Ran Files Coverage
1 6229798680264704.1 89
62.81
Source Files on build 6229798680264704