facebookincubator / TTPForge

57%

main: 67%

LAST BUILD ON BRANCH export-D106692973

branch: export-D106692973

CHANGE BRANCH

x

Reset

Sync Branches

• export-D106692973
• container
• container-fix
• coverage
• dep-lock
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• doc-pc
• expect
• expected-step-failure
• export-D100171959
• export-D100214957
• export-D100219502
• export-D100220109
• export-D102369915
• export-D102381432
• export-D104989832
• export-D50618372
• export-D50635423
• export-D50708311
• export-D50892103
• export-D50990440
• export-D51069461
• export-D51070150
• export-D51139869
• export-D51171741
• export-D51180590
• export-D51306975
• export-D51307671
• export-D51407546
• export-D51428503
• export-D51434166
• export-D51434373
• export-D51435517
• export-D51437115
• export-D51439700
• export-D51449622
• export-D51449668
• export-D51451469
• export-D51457037
• export-D51458305
• export-D51459133
• export-D51459399
• export-D51459508
• export-D51459753
• export-D51467408
• export-D51475492
• export-D51482864
• export-D51495585
• export-D51498587
• export-D51520144
• export-D51520434
• export-D59696048
• export-D59864499
• export-D60238880
• export-D60419102
• export-D60423533
• export-D60686691
• export-D61042469
• export-D61387125
• export-D61657101
• export-D61658174
• export-D61662534
• export-D62530409
• export-D63457210
• export-D63702296
• export-D64108097
• export-D65080213
• export-D65831540
• export-D66702400
• export-D68783463
• export-D69546940
• export-D69863376
• export-D69953549
• export-D70136417
• export-D70192169
• export-D70499233
• export-D71635625
• export-D71739496
• export-D71841703
• export-D72669013
• export-D72670580
• export-D73053704
• export-D76082173
• export-D77463007
• export-D77619765
• export-D78497399
• export-D78521586
• export-D78701235
• export-D78753717
• export-D78761882
• export-D79202811
• export-D79562207
• export-D80822110
• export-D80826527
• export-D81613044
• export-D82462426
• export-D82462427
• export-D82462428
• export-D83680470
• export-D83782620
• export-D84361195
• export-D84760010
• export-D85156300
• export-D85156301
• export-D85156302
• export-D85156303
• export-D85156304
• export-D85156306
• export-D85156307
• export-D85420264
• export-D85961390
• export-D85961391
• export-D85961392
• export-D85980771
• export-D86667764
• export-D86667765
• export-D86701133
• export-D87560637
• export-D87624106
• export-D88201164
• export-D88775033
• export-D88797428
• export-D88953881
• export-D89531176
• export-D89671295
• export-D89671789
• export-D89671793
• export-D90003977
• export-D90004567
• export-D92201696
• export-D92402443
• export-D92490643
• export-D93187902
• export-D94181859
• export-D95083399
• export-D95206129
• export-D95792079
• export-D95792080
• export-D95915751
• export-D95915800
• export-D96483032
• export-D96775202
• export-D96778694
• export-D97167047
• export-D97167049
• export-D98292682
• fix-no-cleanup
• fixup-T168084774-main
• forge-integration-tests
• magefile-updates
• main
• mitre-yaml
• os-and-arch-metadata
• pt-code-owners
• renovate/actions-checkout-3.x
• renovate/actions-checkout-4.x
• renovate/actions-checkout-digest
• renovate/actions-setup-python-digest
• renovate/codespell-project-codespell-2.x
• renovate/docker-build-push-action-5.x
• renovate/docker-build-push-action-digest
• renovate/docker-login-action-3.x
• renovate/docker-setup-buildx-action-3.x
• renovate/docker-setup-buildx-action-digest
• renovate/docker-setup-qemu-action-3.x
• renovate/github-codeql-action-digest
• renovate/github.com-l50-goutils-v2-2.x
• renovate/github.com-spf13-afero-1.x
• renovate/github.com-tidwall-gjson-1.x
• renovate/go.uber.org-zap-1.x
• renovate/golang-1.x
• renovate/goreleaser-goreleaser-action-5.x
• renovate/goreleaser-goreleaser-action-digest
• renovate/pin-dependencies
• renovate/pre-commit-pre-commit-hooks-4.x
• renovate/python-3.x
• renovate/renovatebot-github-action-39.x
• renovate/returntocorp-semgrep-action-digest
• renovate/shogo82148-actions-goveralls-digest
• sfm-create-file-new
• sfm-create-file-step
• sfm-downgrade-afero
• sfm-downgrade-zap
• sfm-dry-run
• sfm-edit-and-create-refactor
• sfm-fix-asdf
• sfm-fix-indirects
• sfm-fix-logs-and-remove-viper
• sfm-fix-template-bug
• sfm-fix-token
• sfm-fix-usage
• sfm-fix-working-directory-handling
• sfm-install-command
• sfm-reduce-minimum-go-version
• sfm-remove-codeowner
• sfm-remove-json-string
• sfm-tmp-remove-vscode
• sfm-update-files-package
• sfm-update-gjson
• sfm-update-zap
• sfm-use-latest-release
• test
• test-refactor

Build # 26843360081

Build Type

Pull #621

github

Committed by facebook-github-bot

Commit Message

Fix Windows cross-compilation error in expect step (#621)

Summary:

The goreleaser build for `windows_amd64` was failing because `pty.Winsize.Cols` is `uint16` on Unix but `uint` on Windows. The explicit `uint16(termWidth)` cast in `expectstep.go` caused a type mismatch when cross-compiling.

Fix uses platform-specific `newWinsize` helpers with build tags, matching the existing pattern from D85156306 (`requirements_unix.go` / `requirements_windows.go`).

Also adds a cross-compilation step to the GitHub Actions test workflow so that builds for all release targets (linux, darwin, windows) are verified on every PR before merge. This would have caught this issue before it landed.

Reviewed By: d0n601

Differential Revision: D106692973

Pull Request Pull Request #621: Fix Windows cross-compilation error in expect step (#621)

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

3238 of 5718 relevant lines covered (56.63%)

15.31 hits per line