facebookincubator / TTPForge
64%
main: 67%

LAST BUILD BRANCH: export-D82462428
DEFAULT BRANCH: main
Repo Added
Token Ra8RGMp9erWTTLNu6nJqTb1aoVijgYIX7 regen
Build 414 Last
Files 69
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH export-D60238880
branch: export-D60238880
CHANGE BRANCH
x
Sync Branches

coverage: 63.954%. First build
10098317734

Pull #503

github

facebook-github-bot 
Refactor expect step, increase test coverage, update pre-commit config

Summary:
**Added:**

- `ssh-pw-expect.yaml`: Demonstrate expect step with SSH password.
- `expect.yaml`: Added YAML front matter for better structuring.
- Introduced `ExpectSpec` struct to encapsulate expect script and responses.
- Detailed comments for `ExpectSpec` attributes.
- Enhanced validation for `ExpectStep`, ensuring `ExpectSpec` is provided.
- Dynamic timeout handling in expect responses.

**Changed:**

- Refactored `expectstep.go`:
  - Introduced `ExpectSpec` for inline script and responses.
  - Improved validation and execution logic for expect steps.
  - Refactored `Execute` method to accommodate `ExpectSpec`.
  - Updated `prepareCommand` method to use `ExpectSpec` inline script.
  - Enhanced logging and error messages in `Execute` and `Validate` methods.
- Updated `expectstep_test.go`:
  - Mocked SSH interaction within expect steps.
  - Refactored test cases for better coverage.
  - Improved logging and error handling across `expectstep.go`.
- Updated tests to reflect changes in `ExpectStep` structure and logic.

**Removed:**

- `.pre-commit-config.yaml`: Removed `go-vet` hook for streamlined configuration.
- Removed unnecessary imports and streamlined existing ones.

Reviewed By: w51d

Differential Revision: D60238880
Pull Request #503: Refactor expect step, increase test coverage, update pre-commit config

30 of 48 new or added lines in 2 files covered. (62.5%)

1792 of 2802 relevant lines covered (63.95%)

13.67 hits per line

Relevant lines Covered
2802 RELEVANT LINES 1792 COVERED LINES
13.67 HITS PER LINE
Source Files on export-D60238880

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
10098317734 export-D60238880 Refactor expect step, increase test coverage, update pre-commit config Summary: **Added:** - `ssh-pw-expect.yaml`: Demonstrate expect step with SSH password. - `expect.yaml`: Added YAML front matter for better structuring. - Introduced `ExpectSp... Pull #503 facebook-github-bot github
63.95
See All Builds (404)