facebookincubator / TTPForge / 26637168684

57%

main: 67%

Pull #621

github

Fix Windows cross-compilation error in expect step

Summary:
The goreleaser build for `windows_amd64` was failing because `pty.Winsize.Cols` is `uint16` on Unix but `uint` on Windows. The explicit `uint16(termWidth)` cast in `expectstep.go` caused a type mismatch when cross-compiling.

Fix uses platform-specific `newWinsize` helpers with build tags, matching the existing pattern from D85156306 (`requirements_unix.go` / `requirements_windows.go`).

Also adds a cross-compilation step to the GitHub Actions test workflow so that builds for all release targets (linux, darwin, windows) are verified on every PR before merge. This would have caught this issue before it landed.

Differential Revision: D106692973

5 of 5 new or added lines in 2 files covered. (100.0%)

3238 of 5718 relevant lines covered (56.63%)

15.31 hits per line