facebookincubator / TTPForge

66%

main: 67%

LAST BUILD ON BRANCH export-D84361195

branch: export-D84361195

CHANGE BRANCH

x

Reset

Sync Branches

• export-D84361195
• container
• container-fix
• coverage
• dep-lock
• dependabot/go_modules/golang.org/x/crypto-0.35.0
• doc-pc
• expect
• expected-step-failure
• export-D50618372
• export-D50635423
• export-D50708311
• export-D50892103
• export-D50990440
• export-D51069461
• export-D51070150
• export-D51139869
• export-D51171741
• export-D51180590
• export-D51306975
• export-D51307671
• export-D51407546
• export-D51428503
• export-D51434166
• export-D51434373
• export-D51435517
• export-D51437115
• export-D51439700
• export-D51449622
• export-D51449668
• export-D51451469
• export-D51457037
• export-D51458305
• export-D51459133
• export-D51459399
• export-D51459508
• export-D51459753
• export-D51467408
• export-D51475492
• export-D51482864
• export-D51495585
• export-D51498587
• export-D51520144
• export-D51520434
• export-D59696048
• export-D59864499
• export-D60238880
• export-D60419102
• export-D60423533
• export-D60686691
• export-D61042469
• export-D61387125
• export-D61657101
• export-D61658174
• export-D61662534
• export-D62530409
• export-D63457210
• export-D63702296
• export-D64108097
• export-D65080213
• export-D65831540
• export-D66702400
• export-D68783463
• export-D69546940
• export-D69863376
• export-D69953549
• export-D70136417
• export-D70192169
• export-D70499233
• export-D71635625
• export-D71739496
• export-D71841703
• export-D72669013
• export-D72670580
• export-D73053704
• export-D76082173
• export-D77463007
• export-D77619765
• export-D78497399
• export-D78521586
• export-D78701235
• export-D78753717
• export-D78761882
• export-D79202811
• export-D79562207
• export-D80822110
• export-D80826527
• export-D81613044
• export-D82462426
• export-D82462427
• export-D82462428
• export-D83680470
• export-D83782620
• export-D84760010
• fix-no-cleanup
• fixup-T168084774-main
• forge-integration-tests
• magefile-updates
• main
• mitre-yaml
• os-and-arch-metadata
• pt-code-owners
• renovate/actions-checkout-3.x
• renovate/actions-checkout-4.x
• renovate/actions-checkout-digest
• renovate/actions-setup-python-digest
• renovate/codespell-project-codespell-2.x
• renovate/docker-build-push-action-5.x
• renovate/docker-build-push-action-digest
• renovate/docker-login-action-3.x
• renovate/docker-setup-buildx-action-3.x
• renovate/docker-setup-buildx-action-digest
• renovate/docker-setup-qemu-action-3.x
• renovate/github-codeql-action-digest
• renovate/github.com-l50-goutils-v2-2.x
• renovate/github.com-spf13-afero-1.x
• renovate/github.com-tidwall-gjson-1.x
• renovate/go.uber.org-zap-1.x
• renovate/golang-1.x
• renovate/goreleaser-goreleaser-action-5.x
• renovate/goreleaser-goreleaser-action-digest
• renovate/pin-dependencies
• renovate/pre-commit-pre-commit-hooks-4.x
• renovate/python-3.x
• renovate/renovatebot-github-action-39.x
• renovate/returntocorp-semgrep-action-digest
• renovate/shogo82148-actions-goveralls-digest
• sfm-create-file-new
• sfm-create-file-step
• sfm-downgrade-afero
• sfm-downgrade-zap
• sfm-dry-run
• sfm-edit-and-create-refactor
• sfm-fix-asdf
• sfm-fix-indirects
• sfm-fix-logs-and-remove-viper
• sfm-fix-template-bug
• sfm-fix-token
• sfm-fix-usage
• sfm-fix-working-directory-handling
• sfm-install-command
• sfm-reduce-minimum-go-version
• sfm-remove-codeowner
• sfm-remove-json-string
• sfm-tmp-remove-vscode
• sfm-update-files-package
• sfm-update-gjson
• sfm-update-zap
• sfm-use-latest-release
• test
• test-refactor

Build # 18419225487

Build Type

Pull #563

github

Committed by facebook-github-bot

Commit Message

Bugfix: Logger config not being respected

Summary:
We currently make two calls to initialize the logger in this order:
- when the logger package is imported with a default configuration
- when we have initialized the configuration with the config we just initialized

However, currently we have wrapped the logger initialization in a do once.  This led to us always setting up a logger with default configurations and ignoring the second call with the configs we actually want.

I opted to remove the init function (which is called when the package is loaded) and instead have the call for the global logger create a new empty config logger if one does not exist yet.   In this case, this means we'll always yield to a provided config, but also that tests can just request and receive a standard logger without needing to create one manually in every test.

Differential Revision: D84361195

Pull Request Pull Request #563: Bugfix: Logger config not being respected

Run Details

2 of 7 new or added lines in 1 file covered. (28.57%)

2718 of 4116 relevant lines covered (66.03%)

16.65 hits per line