facebookincubator / TTPForge
64%
main: 67%

LAST BUILD BRANCH: export-D82462428
DEFAULT BRANCH: main
Repo Added
Token Ra8RGMp9erWTTLNu6nJqTb1aoVijgYIX7 regen
Build 414 Last
Files 69
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH export-D61387125
branch: export-D61387125
CHANGE BRANCH
x
Sync Branches

coverage: 63.821%. First build
10495847045

Pull #509

github

facebook-github-bot 
Properly process powershell nested scripts as TTP steps (#509)

Summary:
Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509

## Problem scope
Let's test with the following simple powershell script
```
% cat nested.ps
echo "start"
if ($true) {
  echo "nested"
}
echo "stop"
```

Here is results of running this script differently
```
% pwsh -File nested.ps
start
nested
stop
% pwsh nested.ps
start
nested
stop
% cat nested.ps | pwsh -File -
PS /data/users/nesusvet/fbsource/fbcode> echo "start"
start
PS /data/users/nesusvet/fbsource/fbcode> if ($true) {
>>   echo "nested"
>> }
>> echo "stop"
>> %
% cat nested.ps | pwsh -Command -
start
```

## Initial proposal
Instead of writing the TTP step body to power shell process stdin, we might rely on a new temp file to hold the body of TTP step to pass it to PowerShell as only argument.  This produces the best results.

### Limitations
Runtime environment where standard golang library call to `os.CreateTemp` fails or the file created is not writable.

## Can We Do Better?

Actually **yes** when we better understand the way PowerShell processes scripts from stdin.
It is expected to wrap your commands into `&{}` block before passing it to PowerShell's stdin.
See [documentation](https://learn.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_pwsh?view=powershell-7.4#-command---c) on `-Command` param for details.

Resolves https://github.com/facebookincubator/TTPForge/issues/481

Reviewed By: CrimsonK1ng

Differential Revision: D61387125
Pull Request #509: Use temp file to process powershell nested scripts as TTP steps

31 of 42 new or added lines in 2 files covered. (73.81%)

1787 of 2800 relevant lines covered (63.82%)

13.66 hits per line

Relevant lines Covered
2800 RELEVANT LINES 1787 COVERED LINES
13.66 HITS PER LINE
Source Files on export-D61387125

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
10495847045 export-D61387125 Properly process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat nested.ps ech... Pull #509 facebook-github-bot github
63.82
10486631795 export-D61387125 Properly process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat nested.ps ech... Pull #509 facebook-github-bot github
63.82
10478065406 export-D61387125 Properly process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat nested.ps ech... Pull #509 facebook-github-bot github
63.84
10475584711 export-D61387125 Properly process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat nested.ps ech... Pull #509 facebook-github-bot github
63.84
10452897637 export-D61387125 Use temp file to process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat neste... Pull #509 facebook-github-bot github
63.32
10452442178 export-D61387125 Use temp file to process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat neste... Pull #509 facebook-github-bot github
63.32
10422202615 export-D61387125 Use temp file to process powershell nested scripts as TTP steps (#509) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/509 ## Problem scope Let's test with the following simple powershell script ``` % cat neste... Pull #509 facebook-github-bot github
63.66
10421993985 export-D61387125 Use temp file to process powershell nested scripts as TTP steps Summary: ## Problem scope Let's test with the following simple powershell script ``` % cat nested.ps echo "start" if ($true) { echo "nested" } echo "stop" ``` Here is results of r... Pull #509 facebook-github-bot github
63.73
See All Builds (404)