facebookincubator / TTPForge
66%
main: 67%

LAST BUILD BRANCH: export-D82462428
DEFAULT BRANCH: main
Repo Added
Token Ra8RGMp9erWTTLNu6nJqTb1aoVijgYIX7 regen
Build 414 Last
Files 69
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH export-D78521586
branch: export-D78521586
CHANGE BRANCH
x
Sync Branches

coverage: 66.361%. First build
16429055613

Pull #545

github

facebook-github-bot 
Kill Process Improvements (#545)

Summary:
Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/545

### Context
Currently the `kill_process` action in TTPForge in cases of failure like `Couldn't find process` and `Couldn't kill process` by default throws an exception which leads to TTP being stopped. While this could be a valid usecase in some situations, allowing user control on whether to throw an error or to print an error and return normally helps make the code versatile.

Following is the decision making in the initial commit of Kill Process Action: [link](https://app.diagrams.net/#G1A4S3RgNffbaMbp40RCpqvmprH1QQvVvi#%7B%22pageId%22%3A%22CNsj_rZLfA5pAP3afiLK%22%7D)
https://pxl.cl/7Lcn3
This flow diagram shows the updated decision making: [link](https://app.diagrams.net/?title=Kill%20Process%20Updated%20Decision%20making.drawio&client=1#G1TePfzl48hKjTKe-K-efOH8F-ASMror7j#%7B%22pageId%22%3A%22CNsj_rZLfA5pAP3afiLK%22%7D)
https://pxl.cl/7Lcmh

### Changes

*   **Code Improvements**: The `kill_process` step has been updated to receive user inputs on actions to take in case of failures like `error_on_find_process_failure` and `error_on_kill_failure`. This facilitates increased control on the code flow by the user to satisfy different needs.
*   **Documentation**: Added an example TTP for reference on the use of the new user inputs for the step `kill_process`.
*   **Testing**: Additional test cases have been added to verify the functionality of the added flags on the `kill_process` step.

### Impact

*   **Improved Usability**: The changes in this diff make it easier for users to control the output of the step on the basis of their needs. (Ignoring or throwing exceptions in cases of failure)

Reviewed By: d0n601

Differential Revision: D78521586
Pull Request #545: Kill Process Improvements

26 of 30 new or added lines in 2 files covered. (86.67%)

2385 of 3594 relevant lines covered (66.36%)

16.43 hits per line

Relevant lines Covered
3594 RELEVANT LINES 2385 COVERED LINES
16.43 HITS PER LINE
Source Files on export-D78521586

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
16429055613 export-D78521586 Kill Process Improvements (#545) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/545 ### Context Currently the `kill_process` action in TTPForge in cases of failure like `Couldn't find process` and `Couldn't ki... Pull #545 facebook-github-bot github
66.36
16428903618 export-D78521586 Kill Process Improvements Summary: ### Context Currently the `kill_process` action in TTPForge in cases of failure like `Couldn't find process` and `Couldn't kill process` by default throws an exception which leads to TTP being stopped. While thi... Pull #545 facebook-github-bot github
50.4
See All Builds (404)