facebookincubator / TTPForge
56%
main: 67%

LAST BUILD BRANCH: export-D92402443
DEFAULT BRANCH: main
Repo Added
Token Ra8RGMp9erWTTLNu6nJqTb1aoVijgYIX7 regen
Build 491 Last
Files 82
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH export-D92402443
branch: export-D92402443
CHANGE BRANCH
x
Sync Branches

coverage: 56.096%. First build
21764907505

Pull #595

github

facebook-github-bot 
Fix regex pattern matching for validate command (#595)

Summary:

The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to miss template variables used in more complex Go template expressions such as:
- Conditionals: `{{if .Args.x}}`
- Function calls: `{{printf "%s" .Args.x}}`
- Whitespace variations: `{{ .Args.x }}`

Updated the regex patterns to match `.Args.varname` and `.StepVars.varname` anywhere within their respective template delimiters (`{{ }}` and `{[{ }]}`), ensuring all template variable references are properly validated.

Additionally, fixed false positive errors for StepVars that are defined in subttps. When a TTP references a subttp via the `ttp:` field, the subttp can export outputvars to the parent TTP. Since we cannot validate which variables the subttp produces without loading it, we now emit a warning instead of an error when a StepVar is not found locally but subttp steps exist. This allows valid TTPs like `subttps-and-variables.yaml` to pass validation while still alerting users to potentially undefined variables.

Reviewed By: ivnik

Differential Revision: D92402443
Pull Request #595: Fix regex pattern matching for validate command

0 of 10 new or added lines in 1 file covered. (0.0%)

2848 of 5077 relevant lines covered (56.1%)

14.88 hits per line

Relevant lines Covered
5077 RELEVANT LINES 2848 COVERED LINES
14.88 HITS PER LINE
Source Files on export-D92402443

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
21764907505 export-D92402443 Fix regex pattern matching for validate command (#595) Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to m... Pull #595 facebook-github-bot github
56.1
21764283812 export-D92402443 Fix regex pattern matching for validate command (#595) Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to m... Pull #595 facebook-github-bot github
56.1
21763719111 export-D92402443 Fix regex pattern matching for validate command (#595) Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to m... Pull #595 facebook-github-bot github
56.1
21763493808 export-D92402443 Fix regex pattern matching for validate command (#595) Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to m... Pull #595 facebook-github-bot github
56.1
21762806419 export-D92402443 Fix regex pattern matching for validate command Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to miss temp... Pull #595 facebook-github-bot github
56.1
21756244028 export-D92402443 Fix regex pattern matching for validate command (#595) Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to m... Pull #595 facebook-github-bot github
56.18
21718516228 export-D92402443 Fix regex pattern matching for validate command Summary: The existing regex patterns for `templateVarPattern` and `stepVarsPattern` only matched simple template variable references like `{{.Args.x}}`. This caused the validate command to miss temp... Pull #595 facebook-github-bot github
56.2
See All Builds (481)