facebookincubator / TTPForge
51%
main: 67%

LAST BUILD BRANCH: export-D82462428
DEFAULT BRANCH: main
Repo Added
Token Ra8RGMp9erWTTLNu6nJqTb1aoVijgYIX7 regen
Build 414 Last
Files 69
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH export-D80826527
branch: export-D80826527
CHANGE BRANCH
x
Sync Branches

coverage: 51.302%. First build
17239997386

Pull #551

github

facebook-github-bot 
TTPForge Move Command (#551)

Summary:
Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/551

# Overview
This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subttp references intact.

# Context
This implementation spawned from a growing need for reorganization within the growing list of available forges.

View T234255665: [TTPForge] Create Move TTP Command for additional information.

# Future Improvements
Currently, regex pattern matching is used to find and update existing references. Aditional testing should be done to confirm that the regex patterns being tested only update the appropriate references. Additional handling could be added for partial path matches in cases were paths are dynamically generated based on variable values.

When specifying a reference path for the destination (repo//path/to/ttp), the current implementation uses the repository's first search path to store the file. This could be improved to look through all of the search paths and find one that is the closest to the provided path.

# Changes
- Added `move` command to the root command.
- `move.go` and `move_test.go hold implementation and testing for the `move` command respectively.
- Separated TTPRef parsing out from TTPRef resolution in `repocollection.go`.
- Updated `AbsPath()` in `fileutils.go` to resolve the actual absolute path following any symlinks.

Reviewed By: RoboticPrism

Differential Revision: D80826527
Pull Request #551: TTPForge Move Command

96 of 130 new or added lines in 2 files covered. (73.85%)

1655 of 3226 relevant lines covered (51.3%)

8.73 hits per line

Relevant lines Covered
3226 RELEVANT LINES 1655 COVERED LINES
8.73 HITS PER LINE
Source Files on export-D80826527

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
17239997386 export-D80826527 TTPForge Move Command (#551) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/551 # Overview This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subt... Pull #551 facebook-github-bot github
51.3
17239916408 export-D80826527 TTPForge Move Command (#551) Summary: # Overview This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subttp references intact. # Context This implementation spawned from a growing ne... Pull #551 facebook-github-bot github
66.35
17239386454 export-D80826527 TTPForge Move Command (#551) Summary: Pull Request resolved: https://github.com/facebookincubator/TTPForge/pull/551 # Overview This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subt... Pull #551 facebook-github-bot github
66.35
17239297357 export-D80826527 TTPForge Move Command (#551) Summary: # Overview This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subttp references intact. # Context This implementation spawned from a growing ne... Pull #551 facebook-github-bot github
66.35
17238496905 export-D80826527 TTPForge Move Command Summary: # Overview This diff introduces a `move` command to TTPForge. This command enables you to move forge files while keeping any subttp references intact. # Context This implementation spawned from a growing need for r... Pull #551 facebook-github-bot github
66.35
See All Builds (404)