c-ares / c-ares
92%

DEFAULT BRANCH: main
Repo Added
Files 177
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: main
CHANGE BRANCH
x

coverage: 91.676% (-0.02%) from 91.696%
23720842704

push

github

web-flow 
fix: memory leak of buf in ares_dns_multistring_combined() on OOM (#1110)

If ares_buf_finish_str() fails (returns NULL), it does not free the buf
object. The previous code did not destroy buf on this failure path,
leaking it.

Signed-off-by: David Hotham (@dimbleby)

1 of 2 new or added lines in 1 file covered. (50.0%)

4 existing lines in 1 file now uncovered.

22766 of 24833 relevant lines covered (91.68%)

12938.96 hits per line

Relevant lines Covered
24833 RELEVANT LINES 22766 COVERED LINES
12938.96 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
23720842704 main fix: memory leak of buf in ares_dns_multistring_combined() on OOM (#1110) If ares_buf_finish_str() fails (returns NULL), it does not free the buf object. The previous code did not destroy buf on this failure path, leaking it. Signed-off-by: Davi... push web-flow github
91.68
23720778448 main Fix memory leaks on error paths in two functions (#1109) ares_in_addr_to_sconfig_llist(): Free sconfig before goto fail when ares_llist_insert_last() fails. The allocated sconfig was never inserted into the list, so ares_llist_destroy() in the fa... push web-flow github
91.7
23720746854 main fix: memory leak of buckets in ares_htable_dict_keys() error path (#1108) ares_htable_all_buckets() allocates the buckets array, which is freed on the success path but not on the fail label. If ares_malloc_zero or ares_strdup fails, buckets is le... push web-flow github
91.7
23720685326 main fix: prevent corrupt addrinfo nodes on sockaddr allocation failure (#1112) ares_append_ai_node() appended a node to the linked list before allocating its sockaddr. If the sockaddr malloc failed, the function returned ARES_ENOMEM but left a node o... push web-flow github
91.69
23715046345 main Fix two logic bugs in DNS cookie handling (#1103) Fix https://github.com/c-ares/c-ares/issues/1102: 1. timeval_is_set() uses AND (&&) instead of OR (||). A timestamp with sec != 0 but usec == 0 (or vice versa) is incorrectly treated as "not set"... push web-flow github
91.7
23715033830 main Fix linked list INSERT_BEFORE corruption and array insertdata_first ordering (#1101) Fix https://github.com/c-ares/c-ares/issues/1100: Two bugs in internal data structure utilities: 1. ares_llist_attach_at(): The ARES__LLIST_INSERT_BEFORE case ... push web-flow github
91.72
23715018034 main Fix memory leak of bucket->key in ares_htable_dict_insert error path (#1105) Fix https://github.com/c-ares/c-ares/issues/1104: When ares_htable_dict_insert() fails after duplicating the key (via ares_strdup at line 115) but before successful has... push web-flow github
91.7
23713475629 main Use unsigned type for ares_round_up_pow2_u64 to avoid undefined behavior (#1107) fix https://github.com/c-ares/c-ares/issues/1106: ares_round_up_pow2_u64() operates on ares_int64_t (signed). Right-shift of negative signed values is implementatio... push web-flow github
91.71
23713047820 main Fix undefined behavior in ares_buf_replace() pointer arithmetic (#1099) Fix https://github.com/c-ares/c-ares/issues/1098: The expression `ptr - (size_t)(buf->alloc_buf + buf->offset)` casts a pointer to size_t then subtracts it from another poin... push web-flow github
91.72
23414914394 main Add overflow checks to ares_buf_ensure_space() (#1094) Two integer overflow issues in `ares_buf_ensure_space()` (`src/lib/str/ares_buf.c`): 1. `needed_size++` at line 155 wraps to 0 when `needed_size == SIZE_MAX`, causing the subsequent `remaini... push web-flow github
91.7
See All Builds (1999)