c-ares / c-ares

92%

main: 92%

LAST BUILD ON BRANCH v1.34

branch: v1.34

CHANGE BRANCH

x

Reset

• v1.34
• 1.34.6
• 1.34.6-security
• HEAD
• adig
• adig-ahost-exitcode
• alpine-clang-19
• ares-array-overflow-checks
• array-size-overflow
• autotools-update
• b-mac-gcc
• bagder/manpage-references
• bagder/qnx
• bhouse.qnx
• bhouse.sonarcloud
• bhouse.sonarcloud-2
• ci-fixes
• copyright
• coverity_scan
• defer-tcp-error-after-buffered-parse
• dns-name-255-limit-parser
• dns-validate-rr-counts
• dohpath
• fix-ares-dns-record-duplicate-docs
• fix-ares_send-docs
• fix-bind
• fix-buf-ensure-overflow
• fix-doc-typo
• fix-inet-pton
• fix-set-socket-callback
• fix-setvbuf
• fix-sortlist
• fix/binstr-memleak
• fix/buf-replace-null
• fix/cookie-logic-bugs
• fix/corrupt-addrinfo-nodes
• fix/error-path-memory-leaks
• fix/hash-idx-parens
• fix/htable-dict-keys-leak
• fix/htable-dict-memleak
• fix/htable-malloc-zero
• fix/ifa-netmask-null
• fix/init-read-bytes
• fix/llist-array-bugs
• fix/multistring-buf-leak
• fix/qcache-entry-memleak
• fix/qnx-confstr-sizeof
• fix/raw-rr-tostr
• fix/raw-rr-zero-length
• fix/unregister-wait-uaf
• fix/usec-overflow
• fix/win-sysconfig-null
• fix/win32-iocp-null
• fixci
• fixwin
• fuzzer_policy
• hesiod
• ignore_configchg_init_failures
• improve/windows-sysconfig-safe-join
• issue-993
• leaks
• live-failures
• localhost
• macios
• main
• memory
• memory-leaks
• more-const
• more-record-types
• newer_cmake
• ntp-license
• overflow-safe-allocation
• pkgconfig
• punycode
• qnx
• qnx-config
• qnx-tests
• refs/tags/v1.33.0
• refs/tags/v1.33.1
• refs/tags/v1.34.0
• refs/tags/v1.34.1
• refs/tags/v1.34.2
• refs/tags/v1.34.3
• refs/tags/v1.34.4
• refs/tags/v1.34.5
• refs/tags/v1.34.6
• release-1.34.4
• rnd-xor
• server-rise-fall
• service-strtoul-fix
• size-overflow
• sockopt
• staticlib-name
• strict-rdlength-validation
• tomf/probe-pending
• typo
• ubuntu-latest
• ubuntu-rolling
• v1.23
• v1.24
• v1.25
• v1.26
• v1.27
• v1.28
• v1.29
• v1.30
• v1.31
• v1.32
• v1.33
• validate-port-parsing
• wait_on_monotonic
• win-hosts-path
• windns-fix
• winxp
• winxp-eventloop

Build # 24313359540

Build Type

push

github

Committed by bradh352

Commit Message

Fix zero-length RAW_RR losing type metadata during parsing (#1129)

ares_dns_parse_rr_raw_rr() returned early when rdlength==0 without
setting ARES_RR_RAW_RR_TYPE, so the record's type was lost (left as 0).
Move the type assignment to the top of the function so it is set
unconditionally, before the zero-length early return.

Add test with a hand-crafted DNS packet containing a zero-length RAW_RR
with type 65432, verifying the type survives the parse.

---------

Signed-off-by: David Hotham (@dimbleby)

Coverage Stats

14 of 15 new or added lines in 2 files covered. (93.33%)

4 existing lines in 4 files now uncovered.

22793 of 24849 relevant lines covered (91.73%)

12950.38 hits per line