c-ares / c-ares / 23720685326

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix: prevent corrupt addrinfo nodes on sockaddr allocation failure (#1112)

ares_append_ai_node() appended a node to the linked list before
allocating its sockaddr. If the sockaddr malloc failed, the function
returned ARES_ENOMEM but left a node on the list with ai_addr=NULL and
ai_family=0. Callers iterating the list could then dereference the NULL
ai_addr.

Additionally, the two address-family blocks used independent if
statements rather than else-if, so an invalid aftype silently returned
ARES_SUCCESS with a broken node on the list.

Fix by allocating the sockaddr first, then appending the node only on
success. Reject invalid address families with ARES_EFORMERR. Also fix a
duplicate ai_addr assignment (copy-paste leftover).

Signed-off-by: David Hotham (@dimbleby)

Run Details

11 of 12 new or added lines in 1 file covered. (91.67%)

2 existing lines in 2 files now uncovered.

22766 of 24829 relevant lines covered (91.69%)

12808.08 hits per line