c-ares / c-ares / 23720778448

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix memory leaks on error paths in two functions (#1109)

ares_in_addr_to_sconfig_llist(): Free sconfig before goto fail when
ares_llist_insert_last() fails. The allocated sconfig was never inserted
into the list, so ares_llist_destroy() in the fail label cannot reclaim
it. This matches the pattern already used in the sibling functions
ares_addr_node_to_sconfig_llist() and ares_addrpnode_to_sconfig_llist().

ares_gethostbyname(): Add missing NULL channel guard. Without it, if
channel is NULL, ghbn_arg is allocated and then ares_getaddrinfo()
returns early (its own NULL channel check) without invoking the callback
that would free ghbn_arg. This matches the guards already present in
ares_gethostbyaddr() and ares_getnameinfo().

Signed-off-by: David Hotham (@dimbleby)

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

22770 of 24832 relevant lines covered (91.7%)

12892.14 hits per line