c-ares / c-ares / 23715018034

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix memory leak of bucket->key in ares_htable_dict_insert error path (#1105)

Fix https://github.com/c-ares/c-ares/issues/1104:

When ares_htable_dict_insert() fails after duplicating the key (via
ares_strdup at line 115) but before successful hash table insertion, the
fail label frees bucket->val and bucket but not bucket->key, leaking the
duplicated key string.

Add the missing ares_free(bucket->key) to the error cleanup.

Signed-off-by: Kaixuan Li (@MarkLee131)

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

3 existing lines in 1 file now uncovered.

22767 of 24827 relevant lines covered (91.7%)

12916.75 hits per line