c-ares / c-ares / 23715033830

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix linked list INSERT_BEFORE corruption and array insertdata_first ordering (#1101)

Fix https://github.com/c-ares/c-ares/issues/1100:

Two bugs in internal data structure utilities:

1. ares_llist_attach_at(): The ARES__LLIST_INSERT_BEFORE case updates
at->prev to point to the new node, but never updates the previous node's
next pointer. This breaks forward traversal — the inserted node is
invisible when iterating forward. Add the missing node->prev->next =
node assignment.

2. ares_array_insertdata_first(): Calls ares_array_insert_last() instead
of ares_array_insert_first(), inserting at the wrong end of the array.
Fix the copy-paste error to call insert_first.

Signed-off-by: Kaixuan Li (@MarkLee131)

Run Details

1 of 4 new or added lines in 2 files covered. (25.0%)

1 existing line in 1 file now uncovered.

22774 of 24829 relevant lines covered (91.72%)

12860.96 hits per line