c-ares / c-ares / 23713475629

92%

Build Type

push

github

Committed by web-flow

Commit Message

Use unsigned type for ares_round_up_pow2_u64 to avoid undefined behavior (#1107)

fix https://github.com/c-ares/c-ares/issues/1106:

ares_round_up_pow2_u64() operates on ares_int64_t (signed). Right-shift
of negative signed values is implementation-defined in C, and the final
n++ can overflow a signed 64-bit integer which is undefined behavior.

Change the function signature and caller cast to use ares_uint64_t
(unsigned) where the bit manipulation and overflow behavior are
well-defined.

Signed-off-by: Kaixuan Li (@MarkLee131)

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

22770 of 24828 relevant lines covered (91.71%)

13001.33 hits per line