c-ares / c-ares / 23715046345

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix two logic bugs in DNS cookie handling (#1103)

Fix https://github.com/c-ares/c-ares/issues/1102:

1. timeval_is_set() uses AND (&&) instead of OR (||). A timestamp with
sec != 0 but usec == 0 (or vice versa) is incorrectly treated as "not
set". This causes the cookie regression detection to be silently skipped
whenever a state transition happens at an exact second boundary (usec ==
0).

2. The ARES_COOKIE_UNSUPPORTED state handler at line 326 uses
COOKIE_REGRESSION_TIMEOUT_MS (120s) instead of the intended
COOKIE_UNSUPPORTED_TIMEOUT_MS (300s). This causes c-ares to retry cookie
probing after 2 minutes instead of the designed 5 minutes for servers
that don't support cookies.

Signed-off-by: Kaixuan Li (@MarkLee131)

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

5 existing lines in 4 files now uncovered.

22771 of 24831 relevant lines covered (91.7%)

12758.75 hits per line