• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

c-ares / c-ares / 23715046345
92%

Build:
DEFAULT BRANCH: main
Ran 29 Mar 2026 05:43PM UTC
Jobs 1
Files 177
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

29 Mar 2026 05:40PM UTC coverage: 91.704% (-0.02%) from 91.723%
23715046345

push

github

web-flow
Fix two logic bugs in DNS cookie handling (#1103)

Fix https://github.com/c-ares/c-ares/issues/1102:

1. timeval_is_set() uses AND (&&) instead of OR (||). A timestamp with
sec != 0 but usec == 0 (or vice versa) is incorrectly treated as "not
set". This causes the cookie regression detection to be silently skipped
whenever a state transition happens at an exact second boundary (usec ==
0).

2. The ARES_COOKIE_UNSUPPORTED state handler at line 326 uses
COOKIE_REGRESSION_TIMEOUT_MS (120s) instead of the intended
COOKIE_UNSUPPORTED_TIMEOUT_MS (300s). This causes c-ares to retry cookie
probing after 2 minutes instead of the designed 5 minutes for servers
that don't support cookies.

Signed-off-by: Kaixuan Li (@MarkLee131)

1 of 1 new or added line in 1 file covered. (100.0%)

5 existing lines in 4 files now uncovered.

22771 of 24831 relevant lines covered (91.7%)

12758.75 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
62.73
-0.11% src/lib/record/ares_dns_mapping.c
1
87.75
-0.1% src/lib/record/ares_dns_record.c
1
76.47
-1.96% src/lib/util/ares_math.c
2
92.5
-2.5% src/lib/ares_metrics.c
Jobs
ID Job ID Ran Files Coverage
1 23715046345.1 29 Mar 2026 05:43PM UTC 935
61.3
GitHub Action Run
Source Files on build 23715046345
  • Tree
  • List 177
  • Changed 57
  • Source Changed 0
  • Coverage Changed 57
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • c5c58480 on github
  • Prev Build on main (#23715033830)
  • Next Build on main (#23720685326)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc