NZOI / nztrain

38%

master: 38%

LAST BUILD ON BRANCH contest-relations

branch: contest-relations

CHANGE BRANCH

x

Reset

• contest-relations
• 01-05-Update_devise
• 01-06-Upgrade_has_scope
• 07-19-adjust_default_controller_spec_helper_params_to_never_be_nil
• 12-30-Add_a_tiny_spec_for_the_file_attachments_page
• 303-activerecordstatementinvalid-pgundefinedtable-error-missing-from-clause-entry-for-table-contest_relation
• 321-actionviewtemplateerror-undefined-method-new-for-bigdecimalclass
• NZIC-link-fix
• actions/checkout-4
• actions/ubuntu-22.04
• actions/ubuntu-latest
• add-contest-exporter
• add-contest-exporter-v2
• add-javascript-into-master
• add-puma
• add-pypy
• apt-get-update-before-install
• archive-migrations
• before-action-cont
• better-expand-maybe
• better-expand-maybe-v2
• branch-deploy
• cap3
• change-mailer-address
• change-mailer-templates
• ci-test
• class-names-are-strings
• clean-up-submissions-index
• compiled-evaluators
• contest-after-save-with-spec
• contest-form-validation
• contests-duration-units
• contests-owner-column
• contests-owner-on-show-page
• convert-specs-with-transpec
• dependabot-test-merge-all
• dependabot/bundler/carrierwave-1.3.2
• dependabot/bundler/ffi-1.12.2
• dependabot/bundler/geocoder-1.6.1
• dependabot/bundler/jquery-rails-3.1.3
• dependabot/bundler/jquery-rails-4.4.0
• dependabot/bundler/json-2.3.1
• dependabot/bundler/loofah-2.3.1
• dependabot/bundler/mechanize-2.7.7
• dependabot/bundler/nokogiri-1.10.8
• dependabot/bundler/rack-protection-1.5.5
• dependabot/bundler/rmagick-5.3.0
• dependabot/bundler/rubyzip-1.3.0
• dependabot/bundler/sprockets-3.7.2
• deployed
• deployed-merged-into-master
• disable-async-javascript
• disable-school
• feature/subtask-scoring
• fewer-ci-runs
• fix-ambiguous-matches-in-submission-spec
• fix-bundle-whenever
• fix-current-user-detection-on-scoreboard
• fix-file-attachments
• fix-filelink-path-404
• fix-inspection-formating
• fix-inspection-formatting-float-right-v2
• fix-problemset-truncation
• fix-redis-installer
• fix-statement-visibility-in-importer
• fix-submissions-signed-out
• fix-submissions-spec
• fix-type-mismatch-in-by-user-param
• fixes
• forbid-commas-in-submissions-route
• formats-and-routes
• gemfile-assets-group
• gemfile-production-group
• gh-actions-diff-schema
• gh-actions-skip-assets-gems
• gh-actions-v2
• gh-actions-v2-rebase-1
• gh-actions-v2-suggestions
• gh-actions-v3
• graphite-base/290
• graphite-base/292
• graphite-base/296
• graphite-base/297
• graphite-base/298
• graphite-base/300
• graphite-base/302
• graphite-base/314
• graphite-base/315
• graphite-base/338
• graphite-base/339
• hide-scores-of-deleted-users-below-median
• ignore-ds
• improve-judging-errors
• inspect-formatting-remove-repeat
• interactive-problems
• judging-overhaul
• less-deprecation-warnings
• loofah-rails-5
• mailer-links-use-https
• master
• migration-version
• migrations-timestamps-null
• nginx-installer-https
• nice-messages
• pin-isolate-1.10.1
• pr/remove-hard-coded-nztrain-email
• problem-browing-spec
• public-file-server
• puma
• pygments-2.3.1
• qless
• qless-log-level
• rails-4-1-session-store
• rails-5
• rails-5-0-deprecations
• rails-5-1
• rails-5-before-callback-return
• rails-5-cleanup
• rails-5-deprecations
• rails-5-suggestions
• rails-5-suggestions-v2
• rails.4
• readme-markdown
• redis-installer-cleanup
• redis-installer-fix-pin-7-4-4
• reduce-language-installs
• refactor-logic-for-hiding-scores-below-median
• remove-alias-method-chain
• remove-asset-compressors
• remove-coffeescript
• remove-contest-finish-at-with
• remove-j
• remove-jquery-historyjs
• remove-maxmind-geoip
• remove-newrelic
• remove-nokogiri-deps
• remove-permitted-params-caching
• remove-sass
• remove-squeel
• remove-strong-presenters
• remove-test-cases-test-sets
• remove-transaction-callback
• rspec-persistence-path
• schema-limit-255
• school-management
• scoreboard-reduce-db-queries
• scoreboard-refresh-ajax
• scoreboard-update
• scoreboard-update-v2
• seed-mailer-settings
• seeds
• sentry-apm
• sentry-raven-migration
• server-sidebar-init
• show-all-public-on-scoreboard
• simplify-commands
• skip-wkhtmltopdf-in-ci
• staging
• standarddb-fixes-extra
• standarddb-fixes-manual
• standardrb-1.0.5
• standardrb-fixes
• standardrb-fixes-extra
• standardrb-fixes-manual
• sync-rails-config-v2
• thomas-experiment
• tom93/ci-test
• tom93/ci-test-simplecov
• ubuntu-noble
• update-bundler-1-17
• update-devise-config
• update-json
• update-python
• update-registration
• update-rspec-3.9
• vendor-jquery
• write-out-facebox
• write-out-fixtures-spec-helper
• yui-switch-to-jre
• zero-score-message
• zip.fix

Build # 14627148776

Build Type

Pull #291

github

Committed by bagedevimo

Commit Message

Remove unused actions on ContestRelationsController

Most of these actions were rendered unused in 2da020ef59c5, #destroy was
restored in 112b236cf63e and #update_year_level added in 00c9636d1364.
The rest of these actions seem to be dead code, so lets remove them! Git
history can always bring them back as needed, but none of the code is
particularly interesting so it'd be easy to rewrite, anyway.

I've also added specs to cover off the major functions of
contest_relations_controller, including some permission tests, and
ensured that there is at least a logged in user to slightly mitigate a
leak of information in the response differing between not_found and
unauthorised on ContestRelation objects.

Pull Request Pull Request #291: Remove unused actions on ContestRelationsController

Run Details

7 of 8 new or added lines in 1 file covered. (87.5%)

2274 of 5915 relevant lines covered (38.44%)

5.78 hits per line